Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8538a603 authored by Marco Nelissen's avatar Marco Nelissen
Browse files

Fix integer overflow and divide-by-zero 

Bug: 35763994
Test: ran CTS with and without fix
Change-Id: If835e97ce578d4fa567e33e349e48fb7b2559e0e
parent dd447c35

media/libstagefright/AMRExtractor.cpp

+1 −1
Original line number Diff line number Diff line
@@ -253,7 +253,7 @@ status_t AMRSource::read( 


    int64_t seekTimeUs;

    ReadOptions::SeekMode mode;

    if (options && options->getSeekTo(&seekTimeUs, &mode)) {

    if (mOffsetTableLength > 0 && options && options->getSeekTo(&seekTimeUs, &mode)) {

        size_t size;

        int64_t seekFrame = seekTimeUs / 20000ll;  // 20ms per frame.

        mCurrentTimeUs = seekFrame * 20000ll;

media/libstagefright/NuMediaExtractor.cpp

+1 −1
Original line number Diff line number Diff line
@@ -540,7 +540,7 @@ bool NuMediaExtractor::getTotalBitrate(int64_t *bitrate) const { 
    }



    off64_t size;

    if (mDurationUs >= 0 && mDataSource->getSize(&size) == OK) {

    if (mDurationUs > 0 && mDataSource->getSize(&size) == OK) {

        *bitrate = size * 8000000ll / mDurationUs;  // in bits/sec

        return true;

    }