Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 84be04d5 authored by Praveen Chavan's avatar Praveen Chavan Committed by Ricardo Cerqueira
Browse files

libstagefright: optimize thumbnail generation path 

- Checking for YUV420SP format support is not intended for software
  decoders and can be skipped. This avoids unnecessary creation of
  hardware decoders for checking supported output formats.
- Change the flag from kPreferSoftwareCodecs to kSoftwareCodecsOnly.
  This will force software codecs to be tried first and not just "prefer"
  which helps when a software codec for a particular type of codec (like
  divx) doesn't exist and avods creation of hardware codecs twice in case
  of hardware failure.

Change-Id: I682bca5b6bac5a56f46fe3655cd722fe5f08e1e6
parent 0dc32295

media/libstagefright/StagefrightMetadataRetriever.cpp

+12 −0
Original line number Diff line number Diff line
@@ -148,8 +148,16 @@ static VideoFrame *extractVideoFrameWithCodecFlags( 
    // XXX:

    // Once all vendors support OMX_COLOR_FormatYUV420Planar, we can

    // remove this check and always set the decoder output color format

    // skip this check for software decoders

#ifndef QCOM_HARDWARE

    if (isYUV420PlanarSupported(client, trackMeta)) {

        format->setInt32(kKeyColorFormat, OMX_COLOR_FormatYUV420Planar);

#else

    if (!(flags & OMXCodec::kSoftwareCodecsOnly)) {

        if (isYUV420PlanarSupported(client, trackMeta)) {

            format->setInt32(kKeyColorFormat, OMX_COLOR_FormatYUV420Planar);

        }

#endif

    }



    sp<MediaSource> decoder =
@@ -382,7 +390,11 @@ VideoFrame *StagefrightMetadataRetriever::getFrameAtTime( 


    VideoFrame *frame =

        extractVideoFrameWithCodecFlags(

#ifndef QCOM_HARDWARE

                &mClient, trackMeta, source, OMXCodec::kPreferSoftwareCodecs,

#else

                &mClient, trackMeta, source, OMXCodec::kSoftwareCodecsOnly,

#endif

                timeUs, option);



    if (frame == NULL) {