Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 828f883a authored by Glenn Kasten's avatar Glenn Kasten
Browse files

Fix a couple of fast capture typo bugs 

AudioRecord constructor was not passing flags through to set().
Server-side check was using wrong kind of channel mask.

Change-Id: Ifaa880ec323771e9fd168262be05f3e539f53390
parent 8e085cbe

media/libmedia/AudioRecord.cpp

+2 −2
Original line number Diff line number Diff line
@@ -79,14 +79,14 @@ AudioRecord::AudioRecord( 
        uint32_t notificationFrames,

        int sessionId,

        transfer_type transferType,

        audio_input_flags_t flags __unused)

        audio_input_flags_t flags)

    : mStatus(NO_INIT), mSessionId(AUDIO_SESSION_ALLOCATE),

      mPreviousPriority(ANDROID_PRIORITY_NORMAL),

      mPreviousSchedulingGroup(SP_DEFAULT),

      mProxy(NULL)

{

    mStatus = set(inputSource, sampleRate, format, channelMask, frameCount, cbf, user,

            notificationFrames, false /*threadCanCallJava*/, sessionId, transferType);

            notificationFrames, false /*threadCanCallJava*/, sessionId, transferType, flags);

}



AudioRecord::~AudioRecord()

services/audioflinger/Threads.cpp

+2 −2
Original line number Diff line number Diff line
@@ -5102,8 +5102,8 @@ sp<AudioFlinger::RecordThread::RecordTrack> AudioFlinger::RecordThread::createRe 
            // PCM data

            audio_is_linear_pcm(format) &&

            // mono or stereo

            ( (channelMask == AUDIO_CHANNEL_OUT_MONO) ||

              (channelMask == AUDIO_CHANNEL_OUT_STEREO) ) &&

            ( (channelMask == AUDIO_CHANNEL_IN_MONO) ||

              (channelMask == AUDIO_CHANNEL_IN_STEREO) ) &&

            // hardware sample rate

            // FIXME actually the native hardware sample rate

            (sampleRate == mSampleRate) &&