Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 81bf4d03 authored by Mikhail Naganov's avatar Mikhail Naganov
Browse files

libaudiohal: Add default values for default port IDs 

In aosp/2420554, DeviceHalAidl::mDefault{Input|Output}PortId
fields were missing construction time initializers,
potentially allowing for reading of uninitialized values.

Bug: 205884982
Test: m
Change-Id: I146621a75af53c7973b8978a3c50585b5c1aedda
parent d1500dea

media/libaudiohal/impl/DeviceHalAidl.h

+2 −2
Original line number Diff line number Diff line
@@ -194,8 +194,8 @@ class DeviceHalAidl : public DeviceHalInterface, public ConversionHelperAidl { 
    const std::string mInstance;

    const std::shared_ptr<::aidl::android::hardware::audio::core::IModule> mModule;

    Ports mPorts;

    int32_t mDefaultInputPortId;

    int32_t mDefaultOutputPortId;

    int32_t mDefaultInputPortId = -1;

    int32_t mDefaultOutputPortId = -1;

    PortConfigs mPortConfigs;

    Patches mPatches;

    std::map<audio_patch_handle_t, int32_t /* patch ID */> mFwkHandles;