Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 81ad5ecd authored by Phil Burk's avatar Phil Burk
Browse files

audioflinger: pass return code up from startClient 

Was ignoring failed start.

Bug: 65262790
Test: see bug
Change-Id: I0b1d19adfd50d2b00d86bb82f278b720fcbacdb1
parent 3b224af5

services/audioflinger/Threads.cpp

+4 −0
Original line number Diff line number Diff line
@@ -7633,6 +7633,10 @@ status_t AudioFlinger::MmapThread::start(const AudioClient& client, 
        return NO_ERROR;

    }



    if (!isOutput() && !recordingAllowed(client.packageName, client.clientPid, client.clientUid)) {

        return PERMISSION_DENIED;

    }



    audio_port_handle_t portId = AUDIO_PORT_HANDLE_NONE;



    audio_io_handle_t io = mId;

services/oboeservice/AAudioServiceStreamMMAP.cpp

+3 −3
Original line number Diff line number Diff line
@@ -92,7 +92,7 @@ aaudio_result_t AAudioServiceStreamMMAP::start() { 


    aaudio_result_t result = AAudioServiceStreamBase::start();

    if (!mInService && result == AAUDIO_OK) {

        startClient(mMmapClient, &mClientHandle);

        result = startClient(mMmapClient, &mClientHandle);

    }

    return result;

}
@@ -107,7 +107,7 @@ aaudio_result_t AAudioServiceStreamMMAP::pause() { 
    aaudio_result_t result = AAudioServiceStreamBase::pause();

    // TODO put before base::pause()?

    if (!mInService) {

        stopClient(mClientHandle);

        (void) stopClient(mClientHandle);

    }

    return result;

}
@@ -119,7 +119,7 @@ aaudio_result_t AAudioServiceStreamMMAP::stop() { 
    aaudio_result_t result = AAudioServiceStreamBase::stop();

    // TODO put before base::stop()?

    if (!mInService) {

        stopClient(mClientHandle);

        (void) stopClient(mClientHandle);

    }

    return result;

}