Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8129e799 authored by Ruben Brunk's avatar Ruben Brunk
Browse files

DO NOT MERGE: camera2: Disallow connectDevice for all old HALs. 

(preview only)

Bug: 15515564

Change-Id: I14ab73b130ee5355d9cc8b3602738022a5a18710
parent d8754e07

services/camera/libcameraservice/CameraService.cpp

+2 −3
Original line number Diff line number Diff line
@@ -852,13 +852,12 @@ status_t CameraService::connectDevice( 


        switch(deviceVersion) {

          case CAMERA_DEVICE_API_VERSION_1_0:

            ALOGW("Camera using old HAL version: %d", deviceVersion);

            return -EOPNOTSUPP;

           // TODO: don't allow 2.0  Only allow 2.1 and higher

          case CAMERA_DEVICE_API_VERSION_2_0:

          case CAMERA_DEVICE_API_VERSION_2_1:

          case CAMERA_DEVICE_API_VERSION_3_0:

          case CAMERA_DEVICE_API_VERSION_3_1:

            ALOGW("Camera using old HAL version: %d", deviceVersion);

            return -EOPNOTSUPP;

          case CAMERA_DEVICE_API_VERSION_3_2:

            client = new CameraDeviceClient(this, cameraCb, String16(),

                    cameraId, facing, callingPid, USE_CALLING_UID, getpid());