Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 808e3d55 authored by Dan Austin's avatar Dan Austin
Browse files

Disabling signed integer overflow protection. 

Likely benign integer overflows in the AMR-NB encoder are
causing SIGABRTs under normal speech processing. Disabling
this protection until bug 25597150  is resolved and further
testing can be performed.

Bug: 25409744
Change-Id: Ib40d2e03b84c73c573eca637253ed68977986b11
parent 25283404

media/libstagefright/codecs/amrnb/common/Android.mk

+2 −1
Original line number Diff line number Diff line
@@ -69,7 +69,8 @@ LOCAL_CFLAGS := \ 


LOCAL_CFLAGS += -Werror

LOCAL_CLANG := true

LOCAL_SANITIZE := signed-integer-overflow unsigned-integer-overflow

#addressing b/25409744

#LOCAL_SANITIZE := signed-integer-overflow unsigned-integer-overflow



LOCAL_MODULE := libstagefright_amrnb_common

media/libstagefright/codecs/amrnb/enc/Android.mk

+6 −3
Original line number Diff line number Diff line
@@ -71,7 +71,8 @@ LOCAL_CFLAGS := \ 


LOCAL_CFLAGS += -Werror

LOCAL_CLANG := true

LOCAL_SANITIZE := signed-integer-overflow

#addressing b/25409744

#LOCAL_SANITIZE := signed-integer-overflow



LOCAL_MODULE := libstagefright_amrnbenc
@@ -94,7 +95,8 @@ LOCAL_C_INCLUDES := \ 


LOCAL_CFLAGS += -Werror

LOCAL_CLANG := true

LOCAL_SANITIZE := signed-integer-overflow

#addressing b/25409744

#LOCAL_SANITIZE := signed-integer-overflow



LOCAL_STATIC_LIBRARIES := \

        libstagefright_amrnbenc
@@ -126,7 +128,8 @@ LOCAL_SHARED_LIBRARIES := \ 
    libstagefright_amrnb_common



LOCAL_CLANG := true

LOCAL_SANITIZE := signed-integer-overflow

#addressing b/25409744

#LOCAL_SANITIZE := signed-integer-overflow



LOCAL_MODULE := libstagefright_amrnbenc_test

LOCAL_MODULE_TAGS := tests