Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7de5ac1f authored by Eric Laurent's avatar Eric Laurent
Browse files

audio policy: fix effect handle leak 

Fix ref counting error in AudioPolicyEffect::addInputEffects()
and addOutputSessionEffects()

Bug: 17675112.
Change-Id: I5267d1024a585919f66ead83662e57b78ba53540
parent d5923409

services/audiopolicy/AudioPolicyEffects.cpp

+41 −36
Original line number Diff line number Diff line
@@ -105,11 +105,12 @@ status_t AudioPolicyEffects::addInputEffects(audio_io_handle_t input, 
    inputDesc->mRefCount++;



    ALOGV("addInputEffects(): input: %d, refCount: %d", input, inputDesc->mRefCount);



    if (inputDesc->mRefCount == 1) {

        Vector <EffectDesc *> effects = mInputSources.valueAt(index)->mEffects;

        for (size_t i = 0; i < effects.size(); i++) {

            EffectDesc *effect = effects[i];

        sp<AudioEffect> fx = new AudioEffect(NULL, &effect->mUuid, -1, 0, 0, audioSession, input);

            sp<AudioEffect> fx = new AudioEffect(NULL, &effect->mUuid, -1, 0, 0,

                                                 audioSession, input);

            status_t status = fx->initCheck();

            if (status != NO_ERROR && status != ALREADY_EXISTS) {

                ALOGW("addInputEffects(): failed to create Fx %s on source %d",
@@ -120,11 +121,12 @@ status_t AudioPolicyEffects::addInputEffects(audio_io_handle_t input, 
            for (size_t j = 0; j < effect->mParams.size(); j++) {

                fx->setParameter(effect->mParams[j]);

            }

        ALOGV("addInputEffects(): added Fx %s on source: %d", effect->mName, (int32_t)aliasSource);

            ALOGV("addInputEffects(): added Fx %s on source: %d",

                  effect->mName, (int32_t)aliasSource);

            inputDesc->mEffects.add(fx);

        }

        inputDesc->setProcessorEnabled(true);



    }

    return status;

}
@@ -241,12 +243,14 @@ status_t AudioPolicyEffects::addOutputSessionEffects(audio_io_handle_t output, 
    }

    procDesc->mRefCount++;



    ALOGV("addOutputSessionEffects(): session: %d, refCount: %d", audioSession, procDesc->mRefCount);



    ALOGV("addOutputSessionEffects(): session: %d, refCount: %d",

          audioSession, procDesc->mRefCount);

    if (procDesc->mRefCount == 1) {

        Vector <EffectDesc *> effects = mOutputStreams.valueAt(index)->mEffects;

        for (size_t i = 0; i < effects.size(); i++) {

            EffectDesc *effect = effects[i];

        sp<AudioEffect> fx = new AudioEffect(NULL, &effect->mUuid, 0, 0, 0, audioSession, output);

            sp<AudioEffect> fx = new AudioEffect(NULL, &effect->mUuid, 0, 0, 0,

                                                 audioSession, output);

            status_t status = fx->initCheck();

            if (status != NO_ERROR && status != ALREADY_EXISTS) {

                ALOGE("addOutputSessionEffects(): failed to create Fx  %s on session %d",
@@ -260,7 +264,7 @@ status_t AudioPolicyEffects::addOutputSessionEffects(audio_io_handle_t output, 
        }



        procDesc->setProcessorEnabled(true);



    }

    return status;

}
@@ -281,7 +285,8 @@ status_t AudioPolicyEffects::releaseOutputSessionEffects(audio_io_handle_t outpu 


    EffectVector *procDesc = mOutputSessions.valueAt(index);

    procDesc->mRefCount--;

    ALOGV("releaseOutputSessionEffects(): session: %d, refCount: %d", audioSession, procDesc->mRefCount);

    ALOGV("releaseOutputSessionEffects(): session: %d, refCount: %d",

          audioSession, procDesc->mRefCount);

    if (procDesc->mRefCount == 0) {

        procDesc->setProcessorEnabled(false);

        procDesc->mEffects.clear();