Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7b9e6dbb authored by Wonsik Kim's avatar Wonsik Kim
Browse files

CCodec: read formats after setupInputSurface 

Bug: 169831253
Test: atest android.media.cts.MediaRecorderTest
Change-Id: I5091944f57fdb4a05c31f23f3668b8f5f5c6993f
parent de7ebba5

media/codec2/sfplugin/CCodec.cpp

+16 −4
Original line number Diff line number Diff line
@@ -1479,13 +1479,11 @@ void CCodec::createInputSurface() { 
    status_t err;

    sp<IGraphicBufferProducer> bufferProducer;



    sp<AMessage> inputFormat;

    sp<AMessage> outputFormat;

    uint64_t usage = 0;

    {

        Mutexed<std::unique_ptr<Config>>::Locked configLocked(mConfig);

        const std::unique_ptr<Config> &config = *configLocked;

        inputFormat = config->mInputFormat;

        outputFormat = config->mOutputFormat;

        usage = config->mISConfig ? config->mISConfig->mUsage : 0;

    }
@@ -1521,6 +1519,14 @@ void CCodec::createInputSurface() { 
        return;

    }



    // Formats can change after setupInputSurface

    sp<AMessage> inputFormat;

    {

        Mutexed<std::unique_ptr<Config>>::Locked configLocked(mConfig);

        const std::unique_ptr<Config> &config = *configLocked;

        inputFormat = config->mInputFormat;

        outputFormat = config->mOutputFormat;

    }

    mCallback->onInputSurfaceCreated(

            inputFormat,

            outputFormat,
@@ -1570,13 +1576,11 @@ void CCodec::initiateSetInputSurface(const sp<PersistentSurface> &surface) { 
}



void CCodec::setInputSurface(const sp<PersistentSurface> &surface) {

    sp<AMessage> inputFormat;

    sp<AMessage> outputFormat;

    uint64_t usage = 0;

    {

        Mutexed<std::unique_ptr<Config>>::Locked configLocked(mConfig);

        const std::unique_ptr<Config> &config = *configLocked;

        inputFormat = config->mInputFormat;

        outputFormat = config->mOutputFormat;

        usage = config->mISConfig ? config->mISConfig->mUsage : 0;

    }
@@ -1608,6 +1612,14 @@ void CCodec::setInputSurface(const sp<PersistentSurface> &surface) { 
        mCallback->onInputSurfaceDeclined(UNKNOWN_ERROR);

        return;

    }

    // Formats can change after setupInputSurface

    sp<AMessage> inputFormat;

    {

        Mutexed<std::unique_ptr<Config>>::Locked configLocked(mConfig);

        const std::unique_ptr<Config> &config = *configLocked;

        inputFormat = config->mInputFormat;

        outputFormat = config->mOutputFormat;

    }

    mCallback->onInputSurfaceAccepted(inputFormat, outputFormat);

}