Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7b450fa4 authored by Kevin Rocard's avatar Kevin Rocard Committed by android-build-merger
Browse files

Invalid audio effect config could crash the parser 

am: 82e14cda

Change-Id: I134006f5060a03070c2c78433bbb77fd32e92681
parents 28eecdd3 82e14cda

media/libeffects/config/src/EffectsConfig.cpp

+1 −1
Original line number Diff line number Diff line
@@ -203,7 +203,7 @@ bool parseEffect(const XMLElement& xmlEffect, Libraries& libraries, Effects* eff 
        auto parseProxy = [&xmlEffect, &parseImpl](const char* tag, EffectImpl& proxyLib) {

            auto* xmlProxyLib = xmlEffect.FirstChildElement(tag);

            if (xmlProxyLib == nullptr) {

                ALOGE("effectProxy must contain a <%s>: %s", tag, dump(*xmlProxyLib));

                ALOGE("effectProxy must contain a <%s>: %s", tag, dump(xmlEffect));

                return false;

            }

            return parseImpl(*xmlProxyLib, proxyLib);