Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7840c30d authored by Andy Hung's avatar Andy Hung Committed by Eric Laurent
Browse files

Revert "Ignore config error if non-offloadable effect is on offload thread" 

This reverts commit cfb68134.

Reason for revert: Crashes in Play Music b/73624638
Test: Play Music with cleared app data, check equalizer settings
Bug: 73624638
Bug: 70912361
Change-Id: I6d4eec2fda57a60c2c6949937752d8f1e50bb8ab
parent cfb68134

services/audioflinger/Effects.cpp

+0 −7
Original line number Diff line number Diff line
@@ -589,13 +589,6 @@ status_t AudioFlinger::EffectModule::configure() 
        status = cmdStatus;

    }



    // Ignore error if non-offloadable effect is created on an offload thread.

    // Will be switched to non-offload thread when the effect is enabled.

    if (status != NO_ERROR && thread->type() == ThreadBase::OFFLOAD && !isOffloaded()) {

        ALOGV("Ignore error %d on non-offloadable effect on offload thread", status);

        status = NO_ERROR;

    }



#ifdef MULTICHANNEL_EFFECT_CHAIN

    if (status != NO_ERROR &&

            (mConfig.inputCfg.channels != AUDIO_CHANNEL_OUT_STEREO