Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7791cf11 authored by Marco Nelissen's avatar Marco Nelissen
Browse files

Fix logging 

Make the log message specify whether it was an encoder or a decoder
that failed to instantiate.

Change-Id: Ie357775114c8dea722d87381c13affdfb19dcde4
parent 0d1004ad

media/libstagefright/ACodec.cpp

+4 −4
Original line number Diff line number Diff line
@@ -3888,6 +3888,7 @@ bool ACodec::UninitializedState::onAllocateComponent(const sp<AMessage> &msg) { 


    AString componentName;

    uint32_t quirks = 0;

    int32_t encoder = false;

    if (msg->findString("componentName", &componentName)) {

        ssize_t index = matchingCodecs.add();

        OMXCodec::CodecNameAndQuirks *entry = &matchingCodecs.editItemAt(index);
@@ -3900,7 +3901,6 @@ bool ACodec::UninitializedState::onAllocateComponent(const sp<AMessage> &msg) { 
    } else {

        CHECK(msg->findString("mime", &mime));



        int32_t encoder;

        if (!msg->findInt32("encoder", &encoder)) {

            encoder = false;

        }
@@ -3936,10 +3936,10 @@ bool ACodec::UninitializedState::onAllocateComponent(const sp<AMessage> &msg) { 


    if (node == NULL) {

        if (!mime.empty()) {

            ALOGE("Unable to instantiate a decoder for type '%s'.",

                 mime.c_str());

            ALOGE("Unable to instantiate a %scoder for type '%s'.",

                    encoder ? "en" : "de", mime.c_str());

        } else {

            ALOGE("Unable to instantiate decoder '%s'.", componentName.c_str());

            ALOGE("Unable to instantiate codec '%s'.", componentName.c_str());

        }



        mCodec->signalError(OMX_ErrorComponentNotFound);