Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 733c7287 authored by Steven Moreland's avatar Steven Moreland Committed by Gerrit Code Review
Browse files

Merge "CameraService: hold onto SensorPrivacyManager"

parents 70ee7b5e 3cf67173

services/camera/libcameraservice/CameraService.cpp

+5 −8
Original line number Diff line number Diff line
@@ -56,7 +56,6 @@ 
#include <media/IMediaHTTPService.h>

#include <media/mediaplayer.h>

#include <mediautils/BatteryNotifier.h>

#include <sensorprivacy/SensorPrivacyManager.h>

#include <utils/Errors.h>

#include <utils/Log.h>

#include <utils/String16.h>
@@ -2853,10 +2852,9 @@ void CameraService::SensorPrivacyPolicy::registerSelf() { 
    if (mRegistered) {

        return;

    }

    SensorPrivacyManager spm;

    spm.addSensorPrivacyListener(this);

    mSensorPrivacyEnabled = spm.isSensorPrivacyEnabled();

    status_t res = spm.linkToDeath(this);

    mSpm.addSensorPrivacyListener(this);

    mSensorPrivacyEnabled = mSpm.isSensorPrivacyEnabled();

    status_t res = mSpm.linkToDeath(this);

    if (res == OK) {

        mRegistered = true;

        ALOGV("SensorPrivacyPolicy: Registered with SensorPrivacyManager");
@@ -2865,9 +2863,8 @@ void CameraService::SensorPrivacyPolicy::registerSelf() { 


void CameraService::SensorPrivacyPolicy::unregisterSelf() {

    Mutex::Autolock _l(mSensorPrivacyLock);

    SensorPrivacyManager spm;

    spm.removeSensorPrivacyListener(this);

    spm.unlinkToDeath(this);

    mSpm.removeSensorPrivacyListener(this);

    mSpm.unlinkToDeath(this);

    mRegistered = false;

    ALOGV("SensorPrivacyPolicy: Unregistered with SensorPrivacyManager");

}

services/camera/libcameraservice/CameraService.h

+2 −0
Original line number Diff line number Diff line
@@ -31,6 +31,7 @@ 
#include <binder/IAppOpsCallback.h>

#include <binder/IUidObserver.h>

#include <hardware/camera.h>

#include <sensorprivacy/SensorPrivacyManager.h>



#include <android/hardware/camera/common/1.0/types.h>
@@ -599,6 +600,7 @@ private: 
            virtual void binderDied(const wp<IBinder> &who);



        private:

            SensorPrivacyManager mSpm;

            wp<CameraService> mService;

            Mutex mSensorPrivacyLock;

            bool mSensorPrivacyEnabled;