Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6f561b93 authored by Abhishek Arya's avatar Abhishek Arya Committed by Android (Google) Code Review
Browse files

Merge "MatroskaExtractor: detect infinite loop when parsing NALs" into klp-dev

parents c37f7f6f 407d475b

media/libstagefright/matroska/MatroskaExtractor.cpp

+7 −1
Original line number Diff line number Diff line
@@ -23,6 +23,7 @@ 
#include "mkvparser.hpp"



#include <media/stagefright/foundation/ADebug.h>

#include <media/stagefright/foundation/AUtils.h>

#include <media/stagefright/foundation/hexdump.h>

#include <media/stagefright/DataSource.h>

#include <media/stagefright/MediaBuffer.h>
@@ -563,7 +564,12 @@ status_t MatroskaSource::read( 
                    TRESPASS();

            }



            if (srcOffset + mNALSizeLen + NALsize > srcSize) {

            if (srcOffset + mNALSizeLen + NALsize <= srcOffset + mNALSizeLen) {

                frame->release();

                frame = NULL;



                return ERROR_MALFORMED;

            } else if (srcOffset + mNALSizeLen + NALsize > srcSize) {

                break;

            }