Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6f51c153 authored by Colin Cross's avatar Colin Cross
Browse files

Fix non-trivial warnings hidden by -isystem

These warnings were hidden by -isystem.

Bug: 31751828
Test: m -j checkbuild
Change-Id: Ibb1aa07a6827fcbd29fc15291fcd90280c0f608d
parent f461f38e
Loading
Loading
Loading
Loading
+1 −1
Original line number Original line Diff line number Diff line
@@ -278,7 +278,7 @@ public:
            if (res != NO_ERROR) {
            if (res != NO_ERROR) {
                return res;
                return res;
            }
            }
            if (i > 0 && !(x > lastx) /* handle nan */
            if ((i > 0 && !(x > lastx)) /* handle nan */
                    || y != y /* handle nan */) {
                    || y != y /* handle nan */) {
                // This is a std::map object which imposes sorted order
                // This is a std::map object which imposes sorted order
                // automatically on emplace.
                // automatically on emplace.
+0 −1
Original line number Original line Diff line number Diff line
@@ -79,7 +79,6 @@ private:


            Mutex                   mLock;
            Mutex                   mLock;
            sp<IRadio>              mIRadio;
            sp<IRadio>              mIRadio;
            const radio_handle_t    mHandle;
            sp<RadioCallback>       mCallback;
            sp<RadioCallback>       mCallback;
};
};


+0 −1
Original line number Original line Diff line number Diff line
@@ -72,7 +72,6 @@ private:


            Mutex                               mLock;
            Mutex                               mLock;
            sp<ISoundTrigger>                   mISoundTrigger;
            sp<ISoundTrigger>                   mISoundTrigger;
            const sound_trigger_module_handle_t mModule;
            sp<SoundTriggerCallback>            mCallback;
            sp<SoundTriggerCallback>            mCallback;
};
};


+0 −1
Original line number Original line Diff line number Diff line
@@ -1239,7 +1239,6 @@ void NBLog::Reader::drawHistogram(String8 *body,
// ---------------------------------------------------------------------------
// ---------------------------------------------------------------------------


NBLog::Merger::Merger(const void *shared, size_t size):
NBLog::Merger::Merger(const void *shared, size_t size):
      mBuffer(NULL),
      mShared((Shared *) shared),
      mShared((Shared *) shared),
      mFifo(mShared != NULL ?
      mFifo(mShared != NULL ?
        new audio_utils_fifo(size, sizeof(uint8_t),
        new audio_utils_fifo(size, sizeof(uint8_t),
+3 −1
Original line number Original line Diff line number Diff line
@@ -133,6 +133,7 @@ public:


    // Entry starting in the given pointer
    // Entry starting in the given pointer
    explicit AbstractEntry(const uint8_t *entry);
    explicit AbstractEntry(const uint8_t *entry);
    virtual ~AbstractEntry() {}


    // build concrete entry of appropriate class from pointer
    // build concrete entry of appropriate class from pointer
    static std::unique_ptr<AbstractEntry> buildEntry(const uint8_t *ptr);
    static std::unique_ptr<AbstractEntry> buildEntry(const uint8_t *ptr);
@@ -164,6 +165,7 @@ class FormatEntry : public AbstractEntry {
public:
public:
    // explicit FormatEntry(const EntryIterator &it);
    // explicit FormatEntry(const EntryIterator &it);
    explicit FormatEntry(const uint8_t *ptr) : AbstractEntry(ptr) {}
    explicit FormatEntry(const uint8_t *ptr) : AbstractEntry(ptr) {}
    virtual ~FormatEntry() {}


    // Entry's format string
    // Entry's format string
    const   char* formatString() const;
    const   char* formatString() const;
@@ -196,6 +198,7 @@ class HistogramEntry : public AbstractEntry {
public:
public:
    explicit HistogramEntry(const uint8_t *ptr) : AbstractEntry(ptr) {
    explicit HistogramEntry(const uint8_t *ptr) : AbstractEntry(ptr) {
    }
    }
    virtual ~HistogramEntry() {}


    virtual int64_t     timestamp() const override;
    virtual int64_t     timestamp() const override;


@@ -516,7 +519,6 @@ private:
    std::vector<NamedReader> mNamedReaders;
    std::vector<NamedReader> mNamedReaders;


    // TODO Need comments on all of these
    // TODO Need comments on all of these
    uint8_t *mBuffer;
    Shared * const mShared;
    Shared * const mShared;
    std::unique_ptr<audio_utils_fifo> mFifo;
    std::unique_ptr<audio_utils_fifo> mFifo;
    std::unique_ptr<audio_utils_fifo_writer> mFifoWriter;
    std::unique_ptr<audio_utils_fifo_writer> mFifoWriter;
Loading