Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6dada6be authored by Pirama Arumuga Nainar's avatar Pirama Arumuga Nainar
Browse files

[TimedTextUnitTest] use shared libstagefright_foundation instead of static

Bug: http://b/197965342

libmedia.so, a dependency of TimedTextUnitTest, also depends on
libstagefright_foundation.so.  If we include libstagefright_foundation.a
when linking TimedTextUnitTest, upstream's lld linker will unnecessarily
fetch symbols from libstagefright_foundation.a to redefine undefined
symbols from libmedia.so.  Switching to libstagefright_foundation.so
instead does not increase the closure of shared libraries needed for
this test.

Test: build with aosp/1809741 which has lld with the above behavior.
Change-Id: I4077a385f8c6233108f09a69260d0bda7a022099
parent 386643fc
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -35,7 +35,6 @@ cc_test {

    static_libs: [
        "libstagefright_timedtext",
        "libstagefright_foundation",
    ],

    include_dirs: [
@@ -46,6 +45,7 @@ cc_test {
        "liblog",
        "libmedia",
        "libbinder",
        "libstagefright_foundation",
    ],

    cflags: [