Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6d2e79bb authored by Harish Mahendrakar's avatar Harish Mahendrakar
Browse files

libeffects: Add host support for reverb modules 

- Removed __unused that is not supported by host toolchain
- Removed unused libdl dependency from libreverbwrapper

Bug: 180116440
Test: run reverb_benchmark on host

Change-Id: Id44248fe3ad77650199bc624ba32e8ad373b4abe
parent b2bb385e

media/libeffects/lvm/benchmarks/Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -28,6 +28,7 @@ cc_benchmark { 
cc_benchmark {

    name: "reverb_benchmark",

    vendor: true,

    host_supported: true,

    include_dirs: [

        "frameworks/av/media/libeffects/lvm/wrapper/Reverb",

    ],

media/libeffects/lvm/lib/Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -140,6 +140,7 @@ cc_library_static { 
    },



    vendor: true,

    host_supported: true,

    srcs: [

        "Reverb/src/LVREV_ApplyNewSettings.cpp",

        "Reverb/src/LVREV_ClearAudioBuffers.cpp",

media/libeffects/lvm/tests/Android.bp

+1 −1
Original line number Diff line number Diff line
@@ -54,7 +54,7 @@ cc_test { 


cc_test {

    name: "reverb_test",

    host_supported: false,

    host_supported: true,

    proprietary: true,



    include_dirs: [

media/libeffects/lvm/wrapper/Android.bp

+1 −1
Original line number Diff line number Diff line
@@ -67,6 +67,7 @@ cc_library { 
    },



    vendor: true,

    host_supported: true,

    srcs: ["Reverb/EffectReverb.cpp"],



    cppflags: [
@@ -83,7 +84,6 @@ cc_library { 
    shared_libs: [

        "libaudioutils",

        "libcutils",

        "libdl",

        "liblog",

    ],

media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp

+2 −2
Original line number Diff line number Diff line
@@ -190,8 +190,8 @@ int Reverb_paramValueSize(int32_t param); 


/* Effect Library Interface Implementation */



extern "C" int EffectCreate(const effect_uuid_t* uuid, int32_t sessionId __unused,

                            int32_t ioId __unused, effect_handle_t* pHandle) {

extern "C" int EffectCreate(const effect_uuid_t* uuid, int32_t /* sessionId __unused */,

                            int32_t /* ioId __unused */, effect_handle_t* pHandle) {

    int ret;

    int i;

    int length = sizeof(gDescriptors) / sizeof(const effect_descriptor_t*);