Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6c9c5014 authored by Mikhail Naganov's avatar Mikhail Naganov
Browse files

AIDL: Consider both inputs and output of r_submix to be "virtual" 

Since the AIDL implementation of the remote submix does support
"connect external device" operation, the framework uses it to assign
a device address to a remote submix pipe. Thus, we should treat
both inputs and outputs as "virtual" connections, that is, they
need to be connected explicitly, however they don't require
a physical device.

Bug: 286914845
Bug: 294976817
Test: live caption scenario
Change-Id: I0e5d13e03ebf0d466080f83cc9373906e9affa36
parent 3d1aa862

media/audioaidlconversion/AidlConversionCppNdk.cpp

+5 −9
Original line number Diff line number Diff line
@@ -508,15 +508,6 @@ const detail::AudioDevicePairs& getAudioDevicePairs() { 
            {

                AUDIO_DEVICE_IN_ECHO_REFERENCE, make_AudioDeviceDescription(

                        AudioDeviceType::IN_ECHO_REFERENCE)

            },

            {

                AUDIO_DEVICE_IN_REMOTE_SUBMIX, make_AudioDeviceDescription(

                         AudioDeviceType::IN_SUBMIX)

            },

            {

                AUDIO_DEVICE_OUT_REMOTE_SUBMIX, make_AudioDeviceDescription(

                        AudioDeviceType::OUT_SUBMIX,

                        GET_DEVICE_DESC_CONNECTION(VIRTUAL))

            }

        }};

        append_AudioDeviceDescription(pairs,
@@ -592,6 +583,11 @@ const detail::AudioDevicePairs& getAudioDevicePairs() { 
                AUDIO_DEVICE_IN_BLE_HEADSET, AUDIO_DEVICE_OUT_BLE_HEADSET,

                AudioDeviceType::IN_HEADSET, AudioDeviceType::OUT_HEADSET,

                GET_DEVICE_DESC_CONNECTION(BT_LE));

        append_AudioDeviceDescription(pairs,

                AUDIO_DEVICE_IN_REMOTE_SUBMIX, AUDIO_DEVICE_OUT_REMOTE_SUBMIX,

                AudioDeviceType::IN_SUBMIX, AudioDeviceType::OUT_SUBMIX,

                GET_DEVICE_DESC_CONNECTION(VIRTUAL));



        return pairs;

    }();

    return pairs;