Commit 6bfac519 authored Mar 04, 2023 by Houxiang Dai Committed by Cherrypicker Worker Mar 24, 2023

Fix codec2 setParameters before successful configure

Calling setParameters() before a successful configure() can lead to a crash. This can happen as a race condition or after a failed configure().

Test:
DTV/MM stress test pass

Bug: 265064014
(cherry picked from https://android-review.googlesource.com/q/commit:3c838360944b31fe2b2bb5e5dd06f66f571b14f2)
Merged-In: Id38f04acf449302d2918d164e9d5e8c1083cc2b3
Change-Id: Id38f04acf449302d2918d164e9d5e8c1083cc2b3

parent 3d82d423

media/libstagefright/MediaCodec.cpp

+3 −0

Original line number	Diff line number	Diff line
		@@ -5584,6 +5584,9 @@ status_t MediaCodec::setParameters(const sp<AMessage> &params) {
		}

		status_t MediaCodec::onSetParameters(const sp<AMessage> &params) {
		if (mState == UNINITIALIZED \|\| mState == INITIALIZING) {
		return NO_INIT;
		}
		updateLowLatency(params);
		mapFormat(mComponentName, params, nullptr, false);
		updateTunnelPeek(params);