Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 680ae443 authored by Shunkai Yao's avatar Shunkai Yao
Browse files

Fix handleSetVolume command 

No reply data for EFFECT_CMD_SET_VOLUME

Bug: 261129656
Test: Enable AIDL
Test: atest android.media.audio.cts.LoudnessEnhancerTest
Change-Id: I4b08308694dbfe1da6cb5b09d68e33c0a59c1c3a
parent 1a7ceedf

media/libaudiohal/impl/EffectConversionHelperAidl.cpp

+5 −5
Original line number Diff line number Diff line
@@ -274,17 +274,17 @@ status_t EffectConversionHelperAidl::handleSetDevice(uint32_t cmdSize, const voi 
    return *static_cast<int32_t*>(pReplyData) = OK;

}

status_t EffectConversionHelperAidl::handleSetVolume(uint32_t cmdSize, const void* pCmdData,

                                                     uint32_t* replySize, void* pReplyData) {

    if (cmdSize != 2 * sizeof(uint32_t) || !pCmdData || !replySize || !pReplyData) {

        ALOGE("%s parameter invalid %u %p %p %p", __func__, cmdSize, pCmdData, replySize,

              pReplyData);

                                                     uint32_t* replySize __unused,

                                                     void* pReplyData __unused) {

    if (cmdSize != 2 * sizeof(uint32_t) || !pCmdData) {

        ALOGE("%s parameter invalid %u %p", __func__, cmdSize, pCmdData);

        return BAD_VALUE;

    }

    Parameter::VolumeStereo volume = {.left = (float)(*(uint32_t*)pCmdData) / (1 << 24),

                                      .right = (float)(*(uint32_t*)pCmdData + 1) / (1 << 24)};

    RETURN_STATUS_IF_ERROR(statusTFromBinderStatus(

            mEffect->setParameter(Parameter::make<Parameter::volumeStereo>(volume))));

    return *static_cast<int32_t*>(pReplyData) = OK;

    return OK;

}



status_t EffectConversionHelperAidl::handleSetOffload(uint32_t cmdSize, const void* pCmdData,