Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 66b1955b authored by Wonsik Kim's avatar Wonsik Kim
Browse files

RELAND CCodec: fix dataspace configured for the input surfaces 

Bug: 193656448
Test: atest android.media.cts.EncodeDecodeTest
Test: atest android.media.cts.VideoDecoderRotationTest
Change-Id: I7d06c3449854e100eb9c679af42e2b45d52b171f
parent dd7f1f7b

media/codec2/sfplugin/CCodec.cpp

+26 −5
Original line number Diff line number Diff line
@@ -1566,15 +1566,36 @@ status_t CCodec::setupInputSurface(const std::shared_ptr<InputSurfaceWrapper> &s 
    // we are now using surface - apply default color aspects to input format - as well as

    // get dataspace

    bool inputFormatChanged = config->updateFormats(Config::IS_INPUT);

    ALOGD("input format %s to %s",

            inputFormatChanged ? "changed" : "unchanged",

            config->mInputFormat->debugString().c_str());



    // configure dataspace

    static_assert(sizeof(int32_t) == sizeof(android_dataspace), "dataspace size mismatch");

    android_dataspace dataSpace = HAL_DATASPACE_UNKNOWN;

    (void)config->mInputFormat->findInt32("android._dataspace", (int32_t*)&dataSpace);



    // The output format contains app-configured color aspects, and the input format

    // has the default color aspects. Use the default for the unspecified params.

    ColorAspects inputColorAspects, colorAspects;

    getColorAspectsFromFormat(config->mOutputFormat, colorAspects);

    getColorAspectsFromFormat(config->mInputFormat, inputColorAspects);

    if (colorAspects.mRange == ColorAspects::RangeUnspecified) {

        colorAspects.mRange = inputColorAspects.mRange;

    }

    if (colorAspects.mPrimaries == ColorAspects::PrimariesUnspecified) {

        colorAspects.mPrimaries = inputColorAspects.mPrimaries;

    }

    if (colorAspects.mTransfer == ColorAspects::TransferUnspecified) {

        colorAspects.mTransfer = inputColorAspects.mTransfer;

    }

    if (colorAspects.mMatrixCoeffs == ColorAspects::MatrixUnspecified) {

        colorAspects.mMatrixCoeffs = inputColorAspects.mMatrixCoeffs;

    }

    android_dataspace dataSpace = getDataSpaceForColorAspects(

            colorAspects, /* mayExtend = */ false);

    surface->setDataSpace(dataSpace);

    setColorAspectsIntoFormat(colorAspects, config->mInputFormat, /* force = */ true);

    config->mInputFormat->setInt32("android._dataspace", int32_t(dataSpace));



    ALOGD("input format %s to %s",

            inputFormatChanged ? "changed" : "unchanged",

            config->mInputFormat->debugString().c_str());



    status_t err = mChannel->setInputSurface(surface);

    if (err != OK) {