Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5b9a611e authored by Andy Hung's avatar Andy Hung
Browse files

AudioPolicyManager: Fix memory leak 

Refbase objects can leak the weakref_impl if created on the stack.
Fix deviceToAudioPort().

Test: see bug
Bug: 295257845
Change-Id: I7d0363b4a1b725bdfa4949b85eb1a78c8b3d8ace
parent f82e1d43

services/audiopolicy/managerdefault/AudioPolicyManager.cpp

+3 −3
Original line number Diff line number Diff line
@@ -459,9 +459,9 @@ status_t AudioPolicyManager::setDeviceConnectionStateInt(const sp<DeviceDescript 
status_t AudioPolicyManager::deviceToAudioPort(audio_devices_t device, const char* device_address,

                                               const char* device_name,

                                               media::AudioPortFw* aidlPort) {

    DeviceDescriptorBase devDescr(device, device_address);

    devDescr.setName(device_name);

    return devDescr.writeToParcelable(aidlPort);

    const auto devDescr = sp<DeviceDescriptorBase>::make(device, device_address);

    devDescr->setName(device_name);

    return devDescr->writeToParcelable(aidlPort);

}



void AudioPolicyManager::setEngineDeviceConnectionState(const sp<DeviceDescriptor> device,