Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 56b41990 authored by Mikhail Naganov's avatar Mikhail Naganov
Browse files

Do not log error codes received from HAL 

audio HAL server already logs them, so logging them here is just
a spam. Only log RPC errors.

Change-Id: I55433d4446215b87099c9ad33f4c352f79109fd1
Test: check logcat
parent 9b46a8f9

media/libaudiohal/ConversionHelperHidl.cpp

+2 −2
Original line number Original line Diff line number Diff line
@@ -91,8 +91,8 @@ status_t ConversionHelperHidl::processReturn(const char* funcName, const Status& 
status_t ConversionHelperHidl::processReturn(

status_t ConversionHelperHidl::processReturn(

        const char* funcName, const Status& status, hardware::audio::V2_0::Result retval) {

        const char* funcName, const Status& status, hardware::audio::V2_0::Result retval) {

    const status_t st = status.isOk() ? analyzeResult(retval) : status.transactionError();

    const status_t st = status.isOk() ? analyzeResult(retval) : status.transactionError();

    ALOGE_IF(st, "%s %p %s: %s (from %s)",

    ALOGE_IF(!status.isOk() && st, "%s %p %s: %s (from rpc)",

            mClassName, this, funcName, strerror(-st), status.isOk() ? "hal" : "rpc");

            mClassName, this, funcName, strerror(-st));

    return st;

    return st;

}

}