Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4edbd8c7 authored by Eric Laurent's avatar Eric Laurent
Browse files

audioflinger: fix duplicating track start with a2dp output suspended 

When the output stream is suspended, we must not wait for the HAL
to exist standby or the kernel position to start moving as this never
happens.

Bug: 281952473
Bug: 218803475
Test: repro steps in bug
Change-Id: I6c4f5d6b4c6a598d21f49e43468dc174571b960a
parent ef881646

services/audioflinger/Threads.cpp

+3 −2
Original line number Diff line number Diff line
@@ -4110,8 +4110,9 @@ NO_THREAD_SAFETY_ANALYSIS // manual locking of AudioFlinger 


            // signal actual start of output stream when the render position reported by the kernel

            // starts moving.

            if (!mStandby && !mHalStarted && mKernelPositionOnStandby !=

                    mTimestamp.mPosition[ExtendedTimestamp::LOCATION_KERNEL]) {

            if (!mHalStarted && ((isSuspended() && (mBytesWritten != 0)) || (!mStandby

                    && (mKernelPositionOnStandby

                            != mTimestamp.mPosition[ExtendedTimestamp::LOCATION_KERNEL])))) {

                mHalStarted = true;

                mWaitHalStartCV.broadcast();

            }