Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4c88e716 authored by Brian Lindahl's avatar Brian Lindahl
Browse files

Add last video render time to bug reports 

The last video render time can be helpful for detecting the point in
time around which a permanent video freeze occurs, allowing one to
pinpoint in system logs other events occurring around that point in
time.

Bug: 293851202
Bug: 295565737
Test: play a video that freezes (see bug) and look at metrics
Change-Id: I4ee46120c825c7e1b7a394e4f20cd5c710a63bc1
parent 94ef4389

media/libstagefright/MediaCodec.cpp

+2 −0
Original line number Diff line number Diff line
@@ -210,6 +210,7 @@ static const char *kCodecShapingEnhanced = "android.media.mediacodec.shaped"; 
// Render metrics

static const char *kCodecPlaybackDurationSec = "android.media.mediacodec.playback-duration-sec";

static const char *kCodecFirstRenderTimeUs = "android.media.mediacodec.first-render-time-us";

static const char *kCodecLastRenderTimeUs = "android.media.mediacodec.last-render-time-us";

static const char *kCodecFramesReleased = "android.media.mediacodec.frames-released";

static const char *kCodecFramesRendered = "android.media.mediacodec.frames-rendered";

static const char *kCodecFramesDropped = "android.media.mediacodec.frames-dropped";
@@ -1168,6 +1169,7 @@ void MediaCodec::updateMediametrics() { 
        const VideoRenderQualityMetrics &m = mVideoRenderQualityTracker.getMetrics();

        if (m.frameReleasedCount > 0) {

            mediametrics_setInt64(mMetricsHandle, kCodecFirstRenderTimeUs, m.firstRenderTimeUs);

            mediametrics_setInt64(mMetricsHandle, kCodecLastRenderTimeUs, m.lastRenderTimeUs);

            mediametrics_setInt64(mMetricsHandle, kCodecFramesReleased, m.frameReleasedCount);

            mediametrics_setInt64(mMetricsHandle, kCodecFramesRendered, m.frameRenderedCount);

            mediametrics_setInt64(mMetricsHandle, kCodecFramesSkipped, m.frameSkippedCount);

media/libstagefright/VideoRenderQualityTracker.cpp

+2 −0
Original line number Diff line number Diff line
@@ -455,6 +455,8 @@ void VideoRenderQualityTracker::processMetricsForRenderedFrame(int64_t contentTi 
    if (mMetrics.firstRenderTimeUs == 0) {

        mMetrics.firstRenderTimeUs = actualRenderTimeUs;

    }

    // Capture the timestamp at which the last frame was rendered

    mMetrics.lastRenderTimeUs = actualRenderTimeUs;



    mMetrics.frameRenderedCount++;

media/libstagefright/include/media/stagefright/VideoRenderQualityTracker.h

+3 −0
Original line number Diff line number Diff line
@@ -38,6 +38,9 @@ struct VideoRenderQualityMetrics { 
    // The render time of the first video frame.

    int64_t firstRenderTimeUs;



    // The render time of the last video frame.

    int64_t lastRenderTimeUs;



    // The number of frames released to be rendered.

    int64_t frameReleasedCount;