Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4aa99a84 authored by Wonsik Kim's avatar Wonsik Kim
Browse files

Add a comment about the order of SetPreferredCodec2ComponentStore() and... 

Add a comment about the order of SetPreferredCodec2ComponentStore() and ComponentStore() in the code.

Bug: 369641052
Test: presubmit
Change-Id: I73bdcf574a2f7f0cfb47c49ad31c8ab446d4ff46
parent 4b92dd5d

media/codec2/hal/aidl/include/codec2/aidl/ComponentStore.h

+7 −0
Original line number Diff line number Diff line
@@ -52,6 +52,13 @@ struct Component; 
using ::aidl::android::hardware::media::bufferpool2::IClientManager;



struct ComponentStore : public BnComponentStore {

    /**

     * Constructor for ComponentStore.

     *

     * IMPORTANT: SetPreferredCodec2ComponentStore() is called in the constructor.

     * Be careful about the order of SetPreferredCodec2ComponentStore() and

     * ComponentStore() in the code.

     */

    ComponentStore(const std::shared_ptr<C2ComponentStore>& store);

    virtual ~ComponentStore();

media/codec2/hal/hidl/1.0/utils/include/codec2/hidl/1.0/ComponentStore.h

+7 −0
Original line number Diff line number Diff line
@@ -55,6 +55,13 @@ using ::android::hardware::Void; 
using ::android::sp;



struct ComponentStore : public IComponentStore {

    /**

     * Constructor for ComponentStore.

     *

     * IMPORTANT: SetPreferredCodec2ComponentStore() is called in the constructor.

     * Be careful about the order of SetPreferredCodec2ComponentStore() and

     * ComponentStore() in the code.

     */

    ComponentStore(const std::shared_ptr<C2ComponentStore>& store);

    virtual ~ComponentStore();

media/codec2/hal/hidl/1.1/utils/include/codec2/hidl/1.1/ComponentStore.h

+7 −0
Original line number Diff line number Diff line
@@ -56,6 +56,13 @@ using ::android::hardware::Void; 
using ::android::sp;



struct ComponentStore : public IComponentStore {

    /**

     * Constructor for ComponentStore.

     *

     * IMPORTANT: SetPreferredCodec2ComponentStore() is called in the constructor.

     * Be careful about the order of SetPreferredCodec2ComponentStore() and

     * ComponentStore() in the code.

     */

    ComponentStore(const std::shared_ptr<C2ComponentStore>& store);

    virtual ~ComponentStore();

media/codec2/hal/hidl/1.2/utils/include/codec2/hidl/1.2/ComponentStore.h

+7 −0
Original line number Diff line number Diff line
@@ -56,6 +56,13 @@ using ::android::hardware::Void; 
using ::android::sp;



struct ComponentStore : public IComponentStore {

    /**

     * Constructor for ComponentStore.

     *

     * IMPORTANT: SetPreferredCodec2ComponentStore() is called in the constructor.

     * Be careful about the order of SetPreferredCodec2ComponentStore() and

     * ComponentStore() in the code.

     */

    ComponentStore(const std::shared_ptr<C2ComponentStore>& store);

    virtual ~ComponentStore();