Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 492141a8 authored by Chih-Hung Hsieh's avatar Chih-Hung Hsieh
Browse files

Do not add quotes around flags argument 

* build/soong will adds quotes around the whole flags
  and preserve the quotes around flags argument.
  The quotes incorrectly became part of a flag's value.
* build/soong adds automatically module directory to
  -header-filter.
* allow new found .h file clang-tidy warnings, not as errors.

Bug: 180862582
Test: make; make with WITH_TIDY=1
Change-Id: Ic4aebedf1e13974aa7400fa256325ca3bff764b9
parent 91b07bce

services/mediametrics/Android.bp

+8 −5
Original line number Diff line number Diff line
@@ -30,7 +30,7 @@ tidy_errors = [ 
    "modernize-loop-convert",

    "modernize-make-shared",

    "modernize-make-unique",

    "modernize-pass-by-value",

    // "modernize-pass-by-value", // found in TimeMachine.h

    "modernize-raw-string-literal",

    "modernize-redundant-void-arg",

    "modernize-replace-auto-ptr",
@@ -38,13 +38,13 @@ tidy_errors = [ 
    "modernize-return-braced-init-list",

    "modernize-shrink-to-fit",

    "modernize-unary-static-assert",

    "modernize-use-auto",  // debatable - auto can obscure type

    // "modernize-use-auto",  // found in MediaMetricsService.h, debatable - auto can obscure type

    "modernize-use-bool-literals",

    "modernize-use-default-member-init",

    "modernize-use-emplace",

    "modernize-use-equals-default",

    "modernize-use-equals-delete",

    "modernize-use-nodiscard",

    // "modernize-use-nodiscard", // found in TimeMachine.h

    "modernize-use-noexcept",

    "modernize-use-nullptr",

    "modernize-use-override",
@@ -57,6 +57,10 @@ tidy_errors = [ 
    // Remove some pedantic stylistic requirements.

    "-google-readability-casting", // C++ casts not always necessary and may be verbose

    "-google-readability-todo",    // do not require TODO(info)



    "-bugprone-unhandled-self-assignment", // found in TimeMachine.h

    "-bugprone-suspicious-string-compare", // found in TimeMachine.h

    "-cert-oop54-cpp", // found in TransactionLog.h

]



cc_defaults {
@@ -88,8 +92,7 @@ cc_defaults { 
    tidy_checks: tidy_errors,

    tidy_checks_as_errors: tidy_errors,

    tidy_flags: [

      "-format-style='file'",

      "--header-filter='frameworks/av/services/mediametrics/'",

      "-format-style=file",

    ],

}