Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 47c2b571 authored by Cheng Li's avatar Cheng Li
Browse files

Reduce the frequency of calls to get_device_api_level 

This API call is made more than 100 times a second, and it's
contributing to more than 1% of total CPU cycles in the Audio Codec HAL
process.

Given that this is static information that doesn't change frequently, we
can move the API call to the constructor and cache the information to be
used later.

Test: manual testing by playing a video

Bug link: https://buganizer.corp.google.com/issues/244443227

Change-Id: I35b215d834bd71d9c725b76dcbc0d9aa597faa34
parent e40c6041

media/codec2/components/aac/C2SoftAacDec.cpp

+3 −2
Original line number Diff line number Diff line
@@ -275,7 +275,8 @@ C2SoftAacDec::C2SoftAacDec( 
      mStreamInfo(nullptr),

      mSignalledError(false),

      mOutputPortDelay(kDefaultOutputPortDelay),

      mOutputDelayRingBuffer(nullptr) {

      mOutputDelayRingBuffer(nullptr),

      mDeviceApiLevel(android_get_device_api_level()) {

}



C2SoftAacDec::~C2SoftAacDec() {
@@ -891,7 +892,7 @@ void C2SoftAacDec::process( 
            work->worklets.front()->output.configUpdate.push_back(

                    C2Param::Copy(currentBoostFactor));



            if (android_get_device_api_level() < __ANDROID_API_S__) {

            if (mDeviceApiLevel < __ANDROID_API_S__) {

                // We used to report DRC compression mode in the output format

                // in Q and R, but stopped doing that in S

                C2StreamDrcCompressionModeTuning::input currentCompressMode(0u,

media/codec2/components/aac/C2SoftAacDec.h

+1 −0
Original line number Diff line number Diff line
@@ -97,6 +97,7 @@ private: 
    int32_t mOutputDelayRingBufferWritePos;

    int32_t mOutputDelayRingBufferReadPos;

    int32_t mOutputDelayRingBufferFilled;

    int mDeviceApiLevel;

    bool outputDelayRingBufferPutSamples(INT_PCM *samples, int numSamples);

    int32_t outputDelayRingBufferGetSamples(INT_PCM *samples, int numSamples);

    int32_t outputDelayRingBufferSamplesAvailable();