Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 46dc714d authored by rago's avatar rago Committed by Ricardo Garcia
Browse files

Fix potential overflow in Visualizer effect 

Bug: 30229821
Change-Id: Idd3c1563dc9d3261e6e168e945005bf133ab2cdb
(cherry picked from commit 099ab280)
parent 4fb531e2

media/libeffects/visualizer/EffectVisualizer.cpp

+9 −0
Original line number Diff line number Diff line
@@ -24,6 +24,7 @@ 
#include <time.h>

#include <math.h>

#include <audio_effects/effect_visualizer.h>

#include <cutils/log.h>





extern "C" {
@@ -597,6 +598,14 @@ int Visualizer_command(effect_handle_t self, uint32_t cmdCode, uint32_t cmdSize, 
        break;



    case VISUALIZER_CMD_MEASURE: {

        if (pReplyData == NULL || replySize == NULL ||

                *replySize < (sizeof(int32_t) * MEASUREMENT_COUNT)) {

            ALOGV("VISUALIZER_CMD_MEASURE() error *replySize %" PRIu32

                    " < (sizeof(int32_t) * MEASUREMENT_COUNT) %" PRIu32, *replySize,

                    sizeof(int32_t) * MEASUREMENT_COUNT);

            android_errorWriteLog(0x534e4554, "30229821");

            return -EINVAL;

        }

        uint16_t peakU16 = 0;

        float sumRmsSquared = 0.0f;

        uint8_t nbValidMeasurements = 0;