Loading media/libaudioclient/AudioTrack.cpp +1 −5 Original line number Diff line number Diff line Loading @@ -236,7 +236,6 @@ status_t AudioTrack::getMetrics(mediametrics::Item * &item) AudioTrack::AudioTrack(const AttributionSourceState& attributionSource) : mClientAttributionSource(attributionSource) { } AudioTrack::AudioTrack( Loading @@ -257,7 +256,6 @@ AudioTrack::AudioTrack( float maxRequiredSpeed, audio_port_handle_t selectedDeviceId) { // make_unique does not aggregate init until c++20 mSetParams = std::make_unique<SetParams>( streamType, sampleRate, format, channelMask, frameCount, flags, callback, notificationFrames, nullptr /*sharedBuffer*/, false /*threadCanCallJava*/, Loading Loading @@ -377,9 +375,6 @@ AudioTrack::~AudioTrack() } void AudioTrack::stopAndJoinCallbacks() { // Prevent nullptr crash if it did not open properly. if (mStatus != NO_ERROR) return; // Make sure that callback function exits in the case where // it is looping on buffer full condition in obtainBuffer(). // Otherwise the callback thread will never exit. Loading Loading @@ -896,6 +891,7 @@ void AudioTrack::stop() const int64_t beginNs = systemTime(); AutoMutex lock(mLock); if (mProxy == nullptr) return; // not successfully initialized. mediametrics::Defer defer([&]() { mediametrics::LogItem(mMetricsId) .set(AMEDIAMETRICS_PROP_EVENT, AMEDIAMETRICS_PROP_EVENT_VALUE_STOP) Loading media/libaudioclient/tests/audiotrack_tests.cpp +3 −0 Original line number Diff line number Diff line Loading @@ -38,6 +38,9 @@ TEST(AudioTrackTestBasic, EmptyAudioTrack) { EXPECT_EQ(NO_INIT, at->initCheck()); EXPECT_EQ(true, at->stopped()); // ensure we do not crash. at->stop(); } TEST(AudioTrackTest, TestPlayTrack) { Loading Loading
media/libaudioclient/AudioTrack.cpp +1 −5 Original line number Diff line number Diff line Loading @@ -236,7 +236,6 @@ status_t AudioTrack::getMetrics(mediametrics::Item * &item) AudioTrack::AudioTrack(const AttributionSourceState& attributionSource) : mClientAttributionSource(attributionSource) { } AudioTrack::AudioTrack( Loading @@ -257,7 +256,6 @@ AudioTrack::AudioTrack( float maxRequiredSpeed, audio_port_handle_t selectedDeviceId) { // make_unique does not aggregate init until c++20 mSetParams = std::make_unique<SetParams>( streamType, sampleRate, format, channelMask, frameCount, flags, callback, notificationFrames, nullptr /*sharedBuffer*/, false /*threadCanCallJava*/, Loading Loading @@ -377,9 +375,6 @@ AudioTrack::~AudioTrack() } void AudioTrack::stopAndJoinCallbacks() { // Prevent nullptr crash if it did not open properly. if (mStatus != NO_ERROR) return; // Make sure that callback function exits in the case where // it is looping on buffer full condition in obtainBuffer(). // Otherwise the callback thread will never exit. Loading Loading @@ -896,6 +891,7 @@ void AudioTrack::stop() const int64_t beginNs = systemTime(); AutoMutex lock(mLock); if (mProxy == nullptr) return; // not successfully initialized. mediametrics::Defer defer([&]() { mediametrics::LogItem(mMetricsId) .set(AMEDIAMETRICS_PROP_EVENT, AMEDIAMETRICS_PROP_EVENT_VALUE_STOP) Loading
media/libaudioclient/tests/audiotrack_tests.cpp +3 −0 Original line number Diff line number Diff line Loading @@ -38,6 +38,9 @@ TEST(AudioTrackTestBasic, EmptyAudioTrack) { EXPECT_EQ(NO_INIT, at->initCheck()); EXPECT_EQ(true, at->stopped()); // ensure we do not crash. at->stop(); } TEST(AudioTrackTest, TestPlayTrack) { Loading