Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4650ff0e authored by James Dong's avatar James Dong
Browse files

Add const to the finders method in MetaData.cpp 

o also fixed the MPEG4Writer writeFtypBox() to take a const pointer to MetaData

Change-Id: Iaecdbe6aeab345f6dc72aac0d19f9704b6e0d28a
parent 43ec1dfc

include/media/stagefright/MPEG4Writer.h

+1 −1
Original line number Diff line number Diff line
@@ -161,7 +161,7 @@ private: 
    void writeCompositionMatrix(int32_t degrees);

    void writeMvhdBox(int64_t durationUs);

    void writeMoovBox(int64_t durationUs);

    void writeFtypBox(MetaData *param);

    void writeFtypBox(const MetaData *param);



    MPEG4Writer(const MPEG4Writer &);

    MPEG4Writer &operator=(const MPEG4Writer &);

include/media/stagefright/MetaData.h

+6 −6
Original line number Diff line number Diff line
@@ -154,16 +154,16 @@ public: 
            int32_t left, int32_t top,

            int32_t right, int32_t bottom);



    bool findCString(uint32_t key, const char **value);

    bool findInt32(uint32_t key, int32_t *value);

    bool findInt64(uint32_t key, int64_t *value);

    bool findFloat(uint32_t key, float *value);

    bool findPointer(uint32_t key, void **value);

    bool findCString(uint32_t key, const char **value) const;

    bool findInt32(uint32_t key, int32_t *value) const;

    bool findInt64(uint32_t key, int64_t *value) const;

    bool findFloat(uint32_t key, float *value) const;

    bool findPointer(uint32_t key, void **value) const;



    bool findRect(

            uint32_t key,

            int32_t *left, int32_t *top,

            int32_t *right, int32_t *bottom);

            int32_t *right, int32_t *bottom) const;



    bool setData(uint32_t key, uint32_t type, const void *data, size_t size);

media/libstagefright/MPEG4Writer.cpp

+1 −1
Original line number Diff line number Diff line
@@ -727,7 +727,7 @@ void MPEG4Writer::writeMoovBox(int64_t durationUs) { 
    endBox();  // moov

}



void MPEG4Writer::writeFtypBox(MetaData *param) {

void MPEG4Writer::writeFtypBox(const MetaData *param) {

    beginBox("ftyp");



    int32_t fileType;

media/libstagefright/MetaData.cpp

+6 −6
Original line number Diff line number Diff line
@@ -83,7 +83,7 @@ bool MetaData::setRect( 
    return setData(key, TYPE_RECT, &r, sizeof(r));

}



bool MetaData::findCString(uint32_t key, const char **value) {

bool MetaData::findCString(uint32_t key, const char **value) const {

    uint32_t type;

    const void *data;

    size_t size;
@@ -96,7 +96,7 @@ bool MetaData::findCString(uint32_t key, const char **value) { 
    return true;

}



bool MetaData::findInt32(uint32_t key, int32_t *value) {

bool MetaData::findInt32(uint32_t key, int32_t *value) const {

    uint32_t type;

    const void *data;

    size_t size;
@@ -111,7 +111,7 @@ bool MetaData::findInt32(uint32_t key, int32_t *value) { 
    return true;

}



bool MetaData::findInt64(uint32_t key, int64_t *value) {

bool MetaData::findInt64(uint32_t key, int64_t *value) const {

    uint32_t type;

    const void *data;

    size_t size;
@@ -126,7 +126,7 @@ bool MetaData::findInt64(uint32_t key, int64_t *value) { 
    return true;

}



bool MetaData::findFloat(uint32_t key, float *value) {

bool MetaData::findFloat(uint32_t key, float *value) const {

    uint32_t type;

    const void *data;

    size_t size;
@@ -141,7 +141,7 @@ bool MetaData::findFloat(uint32_t key, float *value) { 
    return true;

}



bool MetaData::findPointer(uint32_t key, void **value) {

bool MetaData::findPointer(uint32_t key, void **value) const {

    uint32_t type;

    const void *data;

    size_t size;
@@ -159,7 +159,7 @@ bool MetaData::findPointer(uint32_t key, void **value) { 
bool MetaData::findRect(

        uint32_t key,

        int32_t *left, int32_t *top,

        int32_t *right, int32_t *bottom) {

        int32_t *right, int32_t *bottom) const {

    uint32_t type;

    const void *data;

    size_t size;