Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 45930ad4 authored by Andy Hung's avatar Andy Hung
Browse files

audiosystem_tests: Fix false test failures 

Fix the test helper listAudioPorts and listAudioPatches,
which incorrectly fails on retry with BAD_VALUE.

Test: atest audiosystem_tests
Bug: 326655236
Change-Id: I8b7b59941b5029b8711d961ad792ddd64886b4fe
parent 8a54f7c9

media/libaudioclient/tests/audio_test_utils.cpp

+6 −2
Original line number Diff line number Diff line
@@ -565,12 +565,14 @@ status_t listAudioPorts(std::vector<audio_port_v7>& portsVec) { 
    int attempts = 5;

    status_t status;

    unsigned int generation1, generation;

    unsigned int numPorts = 0;

    unsigned int numPorts;

    do {

        if (attempts-- < 0) {

            status = TIMED_OUT;

            break;

        }

        // query for number of ports.

        numPorts = 0;

        status = AudioSystem::listAudioPorts(AUDIO_PORT_ROLE_NONE, AUDIO_PORT_TYPE_NONE, &numPorts,

                                             nullptr, &generation1);

        if (status != NO_ERROR) {
@@ -622,12 +624,14 @@ status_t listAudioPatches(std::vector<struct audio_patch>& patchesVec) { 
    int attempts = 5;

    status_t status;

    unsigned int generation1, generation;

    unsigned int numPatches = 0;

    unsigned int numPatches;

    do {

        if (attempts-- < 0) {

            status = TIMED_OUT;

            break;

        }

        // query for number of patches.

        numPatches = 0;

        status = AudioSystem::listAudioPatches(&numPatches, nullptr, &generation1);

        if (status != NO_ERROR) {

            ALOGE("AudioSystem::listAudioPatches returned error %d", status);