Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4550ed48 authored by Elliott Hughes's avatar Elliott Hughes
Browse files

Remove a use of String16::remove. 

This function, ironically, is being removed. This is one of only two
users, and it's pretty hard to use correctly for anything other than
clearing the entire string. In this case, assigning u"" seems clearer
even in a world where remove() was better implemented.

Test: treehugger
Change-Id: Ia6c7601f4303537a66bc3051e8a7743716367d6c
parent da3489fb

camera/CaptureResult.cpp

+1 −1
Original line number Diff line number Diff line
@@ -89,7 +89,7 @@ status_t CaptureResultExtras::writeToParcel(android::Parcel *parcel) const { 
status_t PhysicalCaptureResultInfo::readFromParcel(const android::Parcel* parcel) {

    status_t res;



    mPhysicalCameraId.remove(mPhysicalCameraId.size());

    mPhysicalCameraId.setTo(u"");

    mPhysicalCameraMetadata.clear();



    if ((res = parcel->readString16(&mPhysicalCameraId)) != OK) {