Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 43c386c8 authored by Mikhail Naganov's avatar Mikhail Naganov
Browse files

audiopolicy: More XML deserializer refactorings 

 -- use root and cur argument names consistently;

 -- replace 'while' loops with 'for' loops;

 -- avoid passing around of 'xmlDoc';

 -- get rid of PtrElement, parametrize adding to collections.

 -- make possible to return immutable elements via Return<>
    container from android::hardware.

Test: Compare dumpsys media.audio_policy A/B, check audio
Change-Id: I5e499bdd7196703c4f788d881f331eb9629bf790
parent a77c9edb

services/audiopolicy/Android.mk

+1 −1
Original line number Diff line number Diff line
@@ -81,7 +81,7 @@ LOCAL_SHARED_LIBRARIES += libmedia_helper 
LOCAL_SHARED_LIBRARIES += libmediametrics



ifeq ($(USE_XML_AUDIO_POLICY_CONF), 1)

LOCAL_SHARED_LIBRARIES += libicuuc libxml2

LOCAL_SHARED_LIBRARIES += libhidlbase libicuuc libxml2



LOCAL_CFLAGS += -DUSE_XML_AUDIO_POLICY_CONF

endif #ifeq ($(USE_XML_AUDIO_POLICY_CONF), 1)

services/audiopolicy/common/managerdefinitions/Android.mk

+1 −1
Original line number Diff line number Diff line
@@ -39,7 +39,7 @@ ifeq ($(USE_XML_AUDIO_POLICY_CONF), 1) 


LOCAL_SRC_FILES += src/Serializer.cpp



LOCAL_SHARED_LIBRARIES += libicuuc libxml2

LOCAL_SHARED_LIBRARIES += libhidlbase libicuuc libxml2



LOCAL_C_INCLUDES += \

    external/libxml2/include \

services/audiopolicy/common/managerdefinitions/src/Serializer.cpp

+143 −158

File changed.

Preview size limit exceeded, changes collapsed.