Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 42f2707b authored by Chien-Yu Chen's avatar Chien-Yu Chen
Browse files

Camera: validate input in releaseRecordingFrame 

Check mem isn't null before using it in releaseRecordingFrame.

Bug: 26164272
Change-Id: I384d4aa2798b6121ae548a6bb618fc0189f96633
parent b53ab34b

services/camera/libcameraservice/api1/CameraClient.cpp

+6 −0
Original line number Diff line number Diff line
@@ -479,6 +479,12 @@ void CameraClient::stopRecording() { 
void CameraClient::releaseRecordingFrame(const sp<IMemory>& mem) {

    Mutex::Autolock lock(mLock);

    if (checkPidAndHardware() != NO_ERROR) return;

    if (mem == nullptr) {

        android_errorWriteWithInfoLog(CameraService::SN_EVENT_LOG_ID, "26164272",

                IPCThreadState::self()->getCallingUid(), nullptr, 0);

        return;

    }



    mHardware->releaseRecordingFrame(mem);

}