Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e2bdbcf authored by Shuzhen Wang's avatar Shuzhen Wang Committed by Automerger Merge Worker
Browse files

Camera: Fix request metadata override for repeating request am: d1d051a0 

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/av/+/12419439

Change-Id: I7cb3e6248213415fada6b388982c3f6c60164bcb
parents a34bbf8b d1d051a0

services/camera/libcameraservice/device3/Camera3Device.cpp

+34 −17
Original line number Diff line number Diff line
@@ -2312,6 +2312,15 @@ sp<Camera3Device::CaptureRequest> Camera3Device::createCaptureRequest( 
        newRequest->mRotateAndCropAuto = false;

    }



    auto zoomRatioEntry =

            newRequest->mSettingsList.begin()->metadata.find(ANDROID_CONTROL_ZOOM_RATIO);

    if (zoomRatioEntry.count > 0 &&

            zoomRatioEntry.data.f[0] == 1.0f) {

        newRequest->mZoomRatioIs1x = true;

    } else {

        newRequest->mZoomRatioIs1x = false;

    }



    return newRequest;

}
@@ -4432,6 +4441,8 @@ status_t Camera3Device::RequestThread::prepareHalRequests() { 
                                parent->mDistortionMappers.end()) {

                            continue;

                        }



                        if (!captureRequest->mDistortionCorrectionUpdated) {

                            res = parent->mDistortionMappers[it->cameraId].correctCaptureRequest(

                                    &(it->metadata));

                            if (res != OK) {
@@ -4440,6 +4451,8 @@ status_t Camera3Device::RequestThread::prepareHalRequests() { 
                                        halRequest->frame_number, strerror(-res), res);

                                return INVALID_OPERATION;

                            }

                            captureRequest->mDistortionCorrectionUpdated = true;

                        }

                    }



                    for (it = captureRequest->mSettingsList.begin();
@@ -4449,11 +4462,11 @@ status_t Camera3Device::RequestThread::prepareHalRequests() { 
                            continue;

                        }



                        camera_metadata_entry_t e = it->metadata.find(ANDROID_CONTROL_ZOOM_RATIO);

                        if (e.count > 0 && e.data.f[0] != 1.0f) {

                        if (!captureRequest->mZoomRatioIs1x) {

                            cameraIdsWithZoom.insert(it->cameraId);

                        }



                        if (!captureRequest->mZoomRatioUpdated) {

                            res = parent->mZoomRatioMappers[it->cameraId].updateCaptureRequest(

                                    &(it->metadata));

                            if (res != OK) {
@@ -4462,8 +4475,11 @@ status_t Camera3Device::RequestThread::prepareHalRequests() { 
                                        halRequest->frame_number, strerror(-res), res);

                                return INVALID_OPERATION;

                            }

                            captureRequest->mZoomRatioUpdated = true;

                        }

                    }

                    if (captureRequest->mRotateAndCropAuto) {

                    if (captureRequest->mRotateAndCropAuto &&

                            !captureRequest->mRotationAndCropUpdated) {

                        for (it = captureRequest->mSettingsList.begin();

                                it != captureRequest->mSettingsList.end(); it++) {

                            auto mapper = parent->mRotateAndCropMappers.find(it->cameraId);
@@ -4477,6 +4493,7 @@ status_t Camera3Device::RequestThread::prepareHalRequests() { 
                                }

                            }

                        }

                        captureRequest->mRotationAndCropUpdated = true;

                    }

                }

            }

services/camera/libcameraservice/device3/Camera3Device.h

+13 −0
Original line number Diff line number Diff line
@@ -517,6 +517,19 @@ class Camera3Device : 
        // overriding of ROTATE_AND_CROP value and adjustment of coordinates

        // in several other controls in both the request and the result

        bool                                mRotateAndCropAuto;

        // Whether this capture request has its zoom ratio set to 1.0x before

        // the framework overrides it for camera HAL consumption.

        bool                                mZoomRatioIs1x;





        // Whether this capture request's distortion correction update has

        // been done.

        bool                                mDistortionCorrectionUpdated = false;

        // Whether this capture request's rotation and crop update has been

        // done.

        bool                                mRotationAndCropUpdated = false;

        // Whether this capture request's zoom ratio update has been done.

        bool                                mZoomRatioUpdated = false;

    };

    typedef List<sp<CaptureRequest> > RequestList;