Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3c5de138 authored by Santiago Seifert's avatar Santiago Seifert
Browse files

Fix heap-buffer-overflow in MPEG4Extractor am: d13a4efc 

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/av/+/15747591

Bug: 201632451
Bug: 188893559
Change-Id: Ie775311a46cb1ddddd30e8cfa882d549b9ddfd05
Merged-In: I31f2b9a4f1b561c4466c76ea2af8dd532622102a
parents c4c8ea3c d13a4efc

media/extractors/mp4/MPEG4Extractor.cpp

100755 → 100644
+13 −2
Original line number Diff line number Diff line
@@ -141,6 +141,7 @@ private: 


    MediaBufferHelper *mBuffer;



    size_t mSrcBufferSize;

    uint8_t *mSrcBuffer;



    bool mIsHeif;
@@ -4664,6 +4665,7 @@ MPEG4Source::MPEG4Source( 
      mNALLengthSize(0),

      mStarted(false),

      mBuffer(NULL),

      mSrcBufferSize(0),

      mSrcBuffer(NULL),

      mIsHeif(itemTable != NULL),

      mItemTable(itemTable),
@@ -4819,6 +4821,7 @@ media_status_t MPEG4Source::start() { 
        // file probably specified a bad max size

        return AMEDIA_ERROR_MALFORMED;

    }

    mSrcBufferSize = max_size;



    mStarted = true;
@@ -4835,6 +4838,7 @@ media_status_t MPEG4Source::stop() { 
        mBuffer = NULL;

    }



    mSrcBufferSize = 0;

    delete[] mSrcBuffer;

    mSrcBuffer = NULL;
@@ -5886,13 +5890,20 @@ media_status_t MPEG4Source::read( 
        // Whole NAL units are returned but each fragment is prefixed by

        // the start code (0x00 00 00 01).

        ssize_t num_bytes_read = 0;

        bool mSrcBufferFitsDataToRead = size <= mSrcBufferSize;

        if (mSrcBufferFitsDataToRead) {

          num_bytes_read = mDataSource->readAt(offset, mSrcBuffer, size);

        } else {

          // We are trying to read a sample larger than the expected max sample size.

          // Fall through and let the failure be handled by the following if.

          android_errorWriteLog(0x534e4554, "188893559");

        }



        if (num_bytes_read < (ssize_t)size) {

            mBuffer->release();

            mBuffer = NULL;



            return AMEDIA_ERROR_IO;

            return mSrcBufferFitsDataToRead ? AMEDIA_ERROR_IO : AMEDIA_ERROR_MALFORMED;

        }



        uint8_t *dstData = (uint8_t *)mBuffer->data();