Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3a4af23c authored by Jayant Chowdhary's avatar Jayant Chowdhary
Browse files

Fix LOG_FATAL_IF parameter ordering in ~AImageReader(). 



Bug: 111411111

Test: Native ImageReader cts tests
Test: enroll; auth on pixel4.

Change-Id: Ib61492fe4d69999405043378df02584cff5903a3
Signed-off-by: default avatarJayant Chowdhary <jchowdhary@google.com>
parent cc0dec6c

media/ndk/NdkImage.cpp

+1 −1
Original line number Diff line number Diff line
@@ -58,7 +58,7 @@ AImage::close(int releaseFenceFd) { 
    if (mIsClosed) {

        return;

    }

    if (!mReader->mIsClosed) {

    if (mReader->mIsOpen) {

        mReader->releaseImageLocked(this, releaseFenceFd);

    }

    // Should have been set to nullptr in releaseImageLocked

media/ndk/NdkImageReader.cpp

+4 −4
Original line number Diff line number Diff line
@@ -274,7 +274,7 @@ AImageReader::AImageReader(int32_t width, 


AImageReader::~AImageReader() {

    Mutex::Autolock _l(mLock);

    LOG_FATAL_IF("AImageReader not closed before destruction", mIsClosed != true);

    LOG_FATAL_IF(mIsOpen, "AImageReader not closed before destruction");

}



media_status_t
@@ -348,16 +348,16 @@ AImageReader::init() { 
    }

    mHandler = new CallbackHandler(this);

    mCbLooper->registerHandler(mHandler);



    mIsOpen = true;

    return AMEDIA_OK;

}



void AImageReader::close() {

    Mutex::Autolock _l(mLock);

    if (mIsClosed) {

    if (!mIsOpen) {

        return;

    }

    mIsClosed = true;

    mIsOpen = false;

    AImageReader_ImageListener nullListener = {nullptr, nullptr};

    setImageListenerLocked(&nullListener);

media/ndk/NdkImageReaderPriv.h

+1 −1
Original line number Diff line number Diff line
@@ -166,7 +166,7 @@ struct AImageReader : public RefBase { 
    native_handle_t*           mWindowHandle = nullptr;



    List<AImage*>              mAcquiredImages;

    bool                       mIsClosed = false;

    bool                       mIsOpen = false;



    Mutex                      mLock;

};