Commit 3989d5c2 authored Apr 21, 2011 by Martin Storsjo

stagefright aacenc: Safeguard against overwriting bits

Previously, if bits above the lowest noBitsToWrite were
set, they would be ORed into the previous cache word,
setting unrelated bits erroneously.

This doesn't noticeably affect the performance of the
codec as a whole.

Change-Id: Ie9935533c4299b8f07cb14485f039a9be9c84016

parent 5e9afe43

media/libstagefright/codecs/aacenc/src/bitbuffer.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -152,6 +152,7 @@ Word16 WriteBits(HANDLE_BIT_BUF hBitBuf,

		wBitPos = hBitBuf->wBitPos;
		wBitPos += noBitsToWrite;
		writeValue &= ~(0xffffffff << noBitsToWrite); // Mask out everything except the lowest noBitsToWrite bits
		writeValue <<= 32 - wBitPos;
		writeValue \|= hBitBuf->cache;