Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3908ce0d authored by Pavan Chikkala's avatar Pavan Chikkala Committed by Ethan Chen
Browse files

audio: Fix to prevent deadlock in AudioEffects 

-Write is blocked waiting for effect chain lock and this causes
decoder thread to wait indefintely.
-Sometimes it is observed that effectschain is locked before
mLPAEffectChain is initialized and but unlocking is skipped if
mLPAEffectChain is initialized in between.Due to this LPA
silence and framework reboot issues are observed as
applyEffectsOn() cannot acquire lock to progress further.
-Use flag to check if all effects have been locked and unlock
accordingly to prevent the deadlock scenario.

CRs-Fixed: 524759

Change-Id: I8328a738f9d8f5a16b449f649d8a3d0c29f8f2ca
parent 5bb0fb50

services/audioflinger/AudioFlinger.cpp

+2 −1
Original line number Diff line number Diff line
@@ -180,7 +180,8 @@ AudioFlinger::AudioFlinger() 
      mIsLowRamDevice(true),

      mIsDeviceTypeKnown(false),

      mGlobalEffectEnableTime(0),

      mPrimaryOutputSampleRate(0)

      mPrimaryOutputSampleRate(0),

      mAllChainsLocked(false)

{

    getpid_cached = getpid();

    char value[PROPERTY_VALUE_MAX];