Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 36d0ca16 authored by Chih-Hung Hsieh's avatar Chih-Hung Hsieh Committed by Chih-hung Hsieh
Browse files

Fix clang-tidy warnings in audio and playerservice. 

* Add explicit keyword to conversion constructors.
Bug: 28341362
* Use const reference type for read-only parameters.
Bug: 30407689
Test: build with WITH_TIDY=1

Change-Id: I265f3b094e08d5705b506b3fbba51439c134af84
Merged-In: I265f3b094e08d5705b506b3fbba51439c134af84
parent 67fbddfd

include/media/AudioSystem.h

+1 −1
Original line number Diff line number Diff line
@@ -312,7 +312,7 @@ public: 


    static audio_mode_t getPhoneState();



    static status_t registerPolicyMixes(Vector<AudioMix> mixes, bool registration);

    static status_t registerPolicyMixes(const Vector<AudioMix>& mixes, bool registration);



    static status_t startAudioSource(const struct audio_port_config *source,

                                      const audio_attributes_t *attributes,

include/media/IAudioPolicyService.h

+1 −1
Original line number Diff line number Diff line
@@ -159,7 +159,7 @@ public: 


    virtual audio_mode_t getPhoneState() = 0;



    virtual status_t registerPolicyMixes(Vector<AudioMix> mixes, bool registration) = 0;

    virtual status_t registerPolicyMixes(const Vector<AudioMix>& mixes, bool registration) = 0;



    virtual status_t startAudioSource(const struct audio_port_config *source,

                                      const audio_attributes_t *attributes,

include/media/RingBuffer.h

+1 −1
Original line number Diff line number Diff line
@@ -39,7 +39,7 @@ public: 
    /**

     * Construct a RingBuffer that can grow up to the given length.

     */

    RingBuffer(size_t length);

    explicit RingBuffer(size_t length);



    /**

     * Forward iterator to this class.  Implements an std:forward_iterator.

media/libmedia/AudioSystem.cpp

+1 −1
Original line number Diff line number Diff line
@@ -1136,7 +1136,7 @@ audio_mode_t AudioSystem::getPhoneState() 
    return aps->getPhoneState();

}



status_t AudioSystem::registerPolicyMixes(Vector<AudioMix> mixes, bool registration)

status_t AudioSystem::registerPolicyMixes(const Vector<AudioMix>& mixes, bool registration)

{

    const sp<IAudioPolicyService>& aps = AudioSystem::get_audio_policy_service();

    if (aps == 0) return PERMISSION_DENIED;

media/libmedia/IAudioPolicyService.cpp

+1 −1
Original line number Diff line number Diff line
@@ -700,7 +700,7 @@ public: 
        return (audio_mode_t)reply.readInt32();

    }



    virtual status_t registerPolicyMixes(Vector<AudioMix> mixes, bool registration)

    virtual status_t registerPolicyMixes(const Vector<AudioMix>& mixes, bool registration)

    {

        Parcel data, reply;

        data.writeInterfaceToken(IAudioPolicyService::getInterfaceDescriptor());