Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 34f28cbb authored by Chih-Hung Hsieh's avatar Chih-Hung Hsieh
Browse files

Fix google-explicit-constructor warnings in audioflinger, audiopolicy. 

* Add explicit keyword to conversion constructors.
Bug: 28341362
Test: build with WITH_TIDY=1

Change-Id: I3b73f0cd73f47be7735cc374306c02301c20588f
parent 1567662f

services/audioflinger/AutoPark.h

+1 −1
Original line number Diff line number Diff line
@@ -21,7 +21,7 @@ template<typename T> class AutoPark { 
public:



    // Park the specific FastThread, which can be nullptr, in hot idle if not currently idling

    AutoPark(const sp<T>& fastThread) : mFastThread(fastThread)

    explicit AutoPark(const sp<T>& fastThread) : mFastThread(fastThread)

    {

        mPreviousCommand = FastThreadState::HOT_IDLE;

        if (fastThread != nullptr) {

services/audioflinger/LinearMap.h

+1 −1
Original line number Diff line number Diff line
@@ -134,7 +134,7 @@ public: 
        FIND_METHOD_START_VALUE,             // No samples in history, using start value

    };



    LinearMap(size_t size)

    explicit LinearMap(size_t size)

            : mSize(size),

              mPos(0), // a circular buffer, so could start anywhere. the first sample is at 1.

              mSamples(0),

services/audiopolicy/common/managerdefinitions/include/AudioRoute.h

+1 −1
Original line number Diff line number Diff line
@@ -36,7 +36,7 @@ typedef enum { 
class AudioRoute  : public virtual RefBase

{

public:

    AudioRoute(audio_route_type_t type) : mType(type) {}

    explicit AudioRoute(audio_route_type_t type) : mType(type) {}



    void setSources(const AudioPortVector &sources) { mSources = sources; }

    const AudioPortVector &getSources() const { return mSources; }

services/audiopolicy/common/managerdefinitions/include/IOProfile.h

+2 −2
Original line number Diff line number Diff line
@@ -110,13 +110,13 @@ private: 
class InputProfile : public IOProfile

{

public:

    InputProfile(const String8 &name) : IOProfile(name, AUDIO_PORT_ROLE_SINK) {}

    explicit InputProfile(const String8 &name) : IOProfile(name, AUDIO_PORT_ROLE_SINK) {}

};



class OutputProfile : public IOProfile

{

public:

    OutputProfile(const String8 &name) : IOProfile(name, AUDIO_PORT_ROLE_SOURCE) {}

    explicit OutputProfile(const String8 &name) : IOProfile(name, AUDIO_PORT_ROLE_SOURCE) {}

};



}; // namespace android