Merge "Bufferpool: Check hidl call return value." into qt-dev (309963bb) · Commits · e / os / android_frameworks_av

media/bufferpool/1.0/BufferPoolClient.cpp

+4 −0

Original line number	Diff line number	Diff line
		@@ -528,6 +528,10 @@ void BufferPoolClient::Impl::trySyncFromRemote() {
		(void) outStatus;
		(void) outBuffer;
		});
		if(!transResult.isOk()) {
		ALOGD("sync from client %lld failed: bufferpool process died.",
		(long long)mConnectionId);
		}
		}
		mRemoteSyncLock.unlock();
		}

+7 −1

Original line number	Diff line number	Diff line
		@@ -261,14 +261,20 @@ void Accessor::Impl::handleInvalidateAck() {
		mBufferPool.mInvalidation.onHandleAck(&observers, &invalidationId);
		}
		// Do not hold lock for send invalidations
		size_t deadClients = 0;
		for (auto it = observers.begin(); it != observers.end(); ++it) {
		const sp<IObserver> observer = it->second;
		if (observer) {
		Return<void> transResult = observer->onMessage(it->first, invalidationId);
		(void) transResult;
		if (!transResult.isOk()) {
		++deadClients;
		}
		}
		}
		if (deadClients > 0) {
		ALOGD("During invalidation found %zu dead clients", deadClients);
		}
		}

		bool Accessor::Impl::isValid() {
		return mBufferPool.isValid();

+4 −0

Original line number	Diff line number	Diff line
		@@ -582,6 +582,10 @@ void BufferPoolClient::Impl::trySyncFromRemote() {
		(void) outStatus;
		(void) outBuffer;
		});
		if (!transResult.isOk()) {
		ALOGD("sync from client %lld failed: bufferpool process died.",
		(long long)mConnectionId);
		}
		}
		mRemoteSyncLock.unlock();
		}