Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2fae4e4c authored by Marco Nelissen's avatar Marco Nelissen
Browse files

Limit mp4 atom size to something reasonable 

Bug: 28615448
Change-Id: I5916f6839b4a9bbee4388a106e7373bcd4154f5a
(cherry picked from commit 7788f121)
parent 890b0db1

media/libstagefright/MPEG4Extractor.cpp

+11 −0
Original line number Diff line number Diff line
@@ -54,6 +54,10 @@ namespace android { 
enum {

    // max track header chunk to return

    kMaxTrackHeaderSize = 32,



    // maximum size of an atom. Some atoms can be bigger according to the spec,

    // but we only allow up to this size.

    kMaxAtomSize = 64 * 1024 * 1024,

};



class MPEG4Source : public MediaSource {
@@ -877,6 +881,13 @@ status_t MPEG4Extractor::parseChunk(off64_t *offset, int depth) { 
        ALOGE("b/23540914");

        return ERROR_MALFORMED;

    }

    if (chunk_type != FOURCC('m', 'd', 'a', 't') && chunk_data_size > kMaxAtomSize) {

        char errMsg[100];

        sprintf(errMsg, "%s atom has size %" PRId64, chunk, chunk_data_size);

        ALOGE("%s (b/28615448)", errMsg);

        android_errorWriteWithInfoLog(0x534e4554, "28615448", -1, errMsg, strlen(errMsg));

        return ERROR_MALFORMED;

    }



    if (chunk_type != FOURCC('c', 'p', 'r', 't')

            && chunk_type != FOURCC('c', 'o', 'v', 'r')