Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2f66b5e3 authored by Jan Sebechlebsky's avatar Jan Sebechlebsky Committed by Ján Sebechlebský
Browse files

Use build flag to safeguard virtual_camera service access 

... in CameraProviderManager.

Bug: 318088136
Bug: 301023410
Test: locally enabling / disabling RELEASE_PACKAGE_VIRTUAL_CAMERA and
rebuilding
Test: atest CameraProviderManagerTest

Change-Id: I275fa268ea67365b968821112a9200e6cdb9fd5d
parent 3637e89d

services/camera/libcameraservice/Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -112,6 +112,7 @@ cc_defaults { 
        "libcameraservice_device_independent",

        "libdynamic_depth",

        "libprocessinfoservice_aidl",

        "libvirtualdevicebuildflags",

        "media_permission-aidl-cpp",

    ],

}

services/camera/libcameraservice/common/CameraProviderManager.cpp

+3 −1
Original line number Diff line number Diff line
@@ -33,6 +33,7 @@ 
#include <future>

#include <inttypes.h>

#include <android_companion_virtualdevice_flags.h>

#include <android_companion_virtualdevice_build_flags.h>

#include <android/binder_manager.h>

#include <android/hidl/manager/1.2/IServiceManager.h>

#include <hidl/ServiceManagement.h>
@@ -3266,7 +3267,8 @@ void CameraProviderManager::filterLogicalCameraIdsLocked( 
}



bool CameraProviderManager::isVirtualCameraHalEnabled() {

    return vd_flags::virtual_camera_service_discovery();

    return vd_flags::virtual_camera_service_discovery() &&

           vd_flags::virtual_camera_service_build_flag();

}



} // namespace android