Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2f5010df authored by Shuzhen Wang's avatar Shuzhen Wang
Browse files

Camera: Make originalDataSpace be const upon stream creation 

The previous logic was wrong(!) where DATASPACE_UNKNOWN shouldn't be
used as an initializtion condition.

Test: CTS and vendor testing
Bug: 139820060
Change-Id: I6b59d40ff796d48fe1804b45c189004f1ecc8c18
parent 85bf8a17

services/camera/libcameraservice/device3/Camera3Stream.cpp

+1 −4
Original line number Diff line number Diff line
@@ -70,7 +70,7 @@ Camera3Stream::Camera3Stream(int id, 
    mFormatOverridden(false),

    mOriginalFormat(format),

    mDataSpaceOverridden(false),

    mOriginalDataSpace(HAL_DATASPACE_UNKNOWN),

    mOriginalDataSpace(dataSpace),

    mPhysicalCameraId(physicalCameraId),

    mLastTimestamp(0) {
@@ -137,9 +137,6 @@ int Camera3Stream::getOriginalFormat() const { 


void Camera3Stream::setDataSpaceOverride(bool dataSpaceOverridden) {

    mDataSpaceOverridden = dataSpaceOverridden;

    if (dataSpaceOverridden && mOriginalDataSpace == HAL_DATASPACE_UNKNOWN) {

        mOriginalDataSpace = camera3_stream::data_space;

    }

}



bool Camera3Stream::isDataSpaceOverridden() const {

services/camera/libcameraservice/device3/Camera3Stream.h

+1 −1
Original line number Diff line number Diff line
@@ -588,7 +588,7 @@ class Camera3Stream : 


    //Keep track of original dataSpace in case it gets overridden

    bool mDataSpaceOverridden;

    android_dataspace mOriginalDataSpace;

    const android_dataspace mOriginalDataSpace;



    String8 mPhysicalCameraId;

    nsecs_t mLastTimestamp;