Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2eeabb1f authored by Mathias Agopian's avatar Mathias Agopian
Browse files

fix [2133133] Software OpenGL ES Lighting is buggy (GL Gears washed out bug) 

A typo caused GL_AMBIENT_AND_DIFFUSE to only set the the ambient color.

Fix another typo which caused the viewer position to be wrong for
specular highlights.

Switch back to eye-space lighting, since there are still some issues
with some demos (San Angeles in particular).
parent ad6516d9

include/private/opengles/gl_context.h

+2 −2
Original line number Diff line number Diff line
@@ -294,7 +294,6 @@ struct light_t { 
    vec4_t      normalizedObjPosition;

    vec4_t      spotDir;

    vec4_t      normalizedSpotDir;

    vec4_t      objViewer;

    GLfixed     spotExp;

    GLfixed     spotCutoff;

    GLfixed     spotCutoffCosine;
@@ -327,9 +326,10 @@ struct lighting_t { 
    material_t          front;

    light_model_t       lightModel;

    color_material_t    colorMaterial;

    vec4_t              implicitSceneEmissionAndAmbient;

    vec4_t              objViewer;

    uint32_t            enabledLights;

    GLboolean           enable;

    vec4_t              implicitSceneEmissionAndAmbient;

    GLenum              shadeModel;

    typedef void (*light_fct_t)(ogles_context_t*, vertex_t*);

    void (*lightVertex)(ogles_context_t* c, vertex_t* v);