Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2b30af88 authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Automerger Merge Worker
Browse files

Merge "cameraserver: system camera rules should be checked before making... 

Merge "cameraserver: system camera rules should be checked before making onPhysicalCameraStatusChanged callbacks." into rvc-dev am: eca178fb

Change-Id: Ic7da476fa8e004b69175eaebbd74a3305bb9239c
parents b9c4c92a eca178fb

services/camera/libcameraservice/CameraService.cpp

+22 −4
Original line number Diff line number Diff line
@@ -467,10 +467,21 @@ void CameraService::onDeviceStatusChanged(const String8& id, 
            logDeviceRemoved(idCombo,

                    String8::format("Device status changed to %d", newStatus));

        }



        // Avoid calling getSystemCameraKind() with mStatusListenerLock held (b/141756275)

        SystemCameraKind deviceKind = SystemCameraKind::PUBLIC;

        if (getSystemCameraKind(id, &deviceKind) != OK) {

            ALOGE("%s: Invalid camera id %s, skipping", __FUNCTION__, id.string());

            return;

        }

        String16 id16(id), physicalId16(physicalId);

        Mutex::Autolock lock(mStatusListenerLock);

        for (auto& listener : mListenerList) {

            if (shouldSkipStatusUpdates(deviceKind, listener->isVendorListener(),

                    listener->getListenerPid(), listener->getListenerUid())) {

                ALOGV("Skipping discovery callback for system-only camera device %s",

                        id.c_str());

                continue;

            }

            listener->getListener()->onPhysicalCameraStatusChanged(mapToInterface(newStatus),

                    id16, physicalId16);

        }
@@ -3757,7 +3768,7 @@ void CameraService::updateStatus(StatusInternal status, const String8& cameraId, 


            Mutex::Autolock lock(mStatusListenerLock);



            notifyPhysicalCameraStatusLocked(mapToInterface(status), cameraId);

            notifyPhysicalCameraStatusLocked(mapToInterface(status), cameraId, deviceKind);



            for (auto& listener : mListenerList) {

                bool isVendorListener = listener->isVendorListener();
@@ -3875,7 +3886,8 @@ status_t CameraService::setTorchStatusLocked(const String8& cameraId, 
    return OK;

}



void CameraService::notifyPhysicalCameraStatusLocked(int32_t status, const String8& cameraId) {

void CameraService::notifyPhysicalCameraStatusLocked(int32_t status, const String8& cameraId,

        SystemCameraKind deviceKind) {

    Mutex::Autolock lock(mCameraStatesLock);

    for (const auto& state : mCameraStates) {

        std::vector<std::string> physicalCameraIds;
@@ -3891,6 +3903,12 @@ void CameraService::notifyPhysicalCameraStatusLocked(int32_t status, const Strin 


        String16 id16(state.first), physicalId16(cameraId);

        for (auto& listener : mListenerList) {

            if (shouldSkipStatusUpdates(deviceKind, listener->isVendorListener(),

                    listener->getListenerPid(), listener->getListenerUid())) {

                ALOGV("Skipping discovery callback for system-only camera device %s",

                        cameraId.c_str());

                continue;

            }

            listener->getListener()->onPhysicalCameraStatusChanged(status,

                    id16, physicalId16);

        }

services/camera/libcameraservice/CameraService.h

+2 −1
Original line number Diff line number Diff line
@@ -1005,7 +1005,8 @@ private: 
            hardware::camera::common::V1_0::TorchModeStatus status);



    // notify physical camera status when the physical camera is public.

    void notifyPhysicalCameraStatusLocked(int32_t status, const String8& cameraId);

    void notifyPhysicalCameraStatusLocked(int32_t status, const String8& cameraId,

            SystemCameraKind deviceKind);



    // IBinder::DeathRecipient implementation

    virtual void        binderDied(const wp<IBinder> &who);