Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 29d39630 authored by Treehugger Robot's avatar Treehugger Robot Committed by Gerrit Code Review
Browse files

Merge "CCodec: fix handling buffers in extra slots"

parents e05752e5 fb5ca490

media/codec2/sfplugin/CCodecBufferChannel.cpp

+4 −4
Original line number Diff line number Diff line
@@ -248,7 +248,7 @@ status_t CCodecBufferChannel::queueInputBufferInternal( 
                bool released = input->buffers->releaseBuffer(buffer, nullptr, true);

                ALOGV("[%s] queueInputBuffer: buffer copied; %sreleased",

                      mName, released ? "" : "not ");

                buffer.clear();

                buffer = copy;

            } else {

                ALOGW("[%s] queueInputBuffer: failed to copy a buffer; this may cause input "

                      "buffer starvation on component.", mName);
@@ -335,10 +335,10 @@ status_t CCodecBufferChannel::queueInputBufferInternal( 
    } else {

        Mutexed<Input>::Locked input(mInput);

        bool released = false;

        if (buffer) {

            released = input->buffers->releaseBuffer(buffer, nullptr, true);

        } else if (copy) {

        if (copy) {

            released = input->extraBuffers.releaseSlot(copy, nullptr, true);

        } else if (buffer) {

            released = input->buffers->releaseBuffer(buffer, nullptr, true);

        }

        ALOGV("[%s] queueInputBuffer: buffer%s %sreleased",

              mName, (buffer == nullptr) ? "(copy)" : "", released ? "" : "not ");

media/codec2/sfplugin/CCodecBuffers.cpp

+1 −0
Original line number Diff line number Diff line
@@ -129,6 +129,7 @@ sp<Codec2Buffer> InputBuffers::cloneAndReleaseBuffer(const sp<MediaCodecBuffer> 
    if (!copy->copy(c2buffer)) {

        return nullptr;

    }

    copy->meta()->extend(buffer->meta());

    return copy;

}