Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 28c70d58 authored by Treehugger Robot's avatar Treehugger Robot Committed by Gerrit Code Review
Browse files

Merge "MediaCodec: require Crypto/Descrambler object for secure codecs" into main

parents a20af38c 8147140b

media/aconfig/codec_fwk.aconfig

+10 −0
Original line number Diff line number Diff line
@@ -97,6 +97,16 @@ flag { 
  bug: "325549730"

}



flag {

  name: "secure_codecs_require_crypto"

  namespace: "codec_fwk"

  description: "Bugfix flag for requiring setting crypto for secure codecs"

  bug: "365162324"

  metadata {

    purpose: PURPOSE_BUGFIX

  }

}



flag {

  name: "set_callback_stall"

  namespace: "codec_fwk"

media/libstagefright/MediaCodec.cpp

+6 −1
Original line number Diff line number Diff line
@@ -2459,8 +2459,13 @@ status_t MediaCodec::configure( 
            mediametrics_setInt32(nextMetricsHandle, kCodecCrypto, 1);

        }

    } else if (mFlags & kFlagIsSecure) {

        if (android::media::codec::provider_->secure_codecs_require_crypto()) {

            mErrorLog.log(LOG_TAG, "Crypto or descrambler must be given for secure codec");

            return INVALID_OPERATION;

        } else {

            ALOGW("Crypto or descrambler should be given for secure codec");

        }

    }



    if (mConfigureMsg != nullptr) {

        // if re-configuring, we have one of these from before.